Best guess at modified entrypoint.sh #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2025
Contributor
|
Nice! This will need many of the changes I made in https://github.com/LabKey/Dockerfile/pull/134/files (esp this one), so that non-LabKey users can build images with their own full log4j configs. (I can pull this branch and add them, if you like). I also think we should rename the new mini log4j config to 'composite.log4j2.xml' or something, so its clear what it is for. And update the readme. |
labkey-willm
requested changes
Feb 12, 2025
Modified log4j2 config to only provide overrides
Sigmonia
force-pushed
the
fb_compositeLog4j
branch
from
b65b634 to
45db8a9
Compare
labkey-willm
requested changes
Mar 10, 2025
Contributor
labkey-willm
left a comment
labkey-willm
left a comment
There was a problem hiding this comment.
found a couple things to clean up.
Sigmonia
commented
Mar 11, 2025
labkey-willm
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified log4j2 config to only provide overrides
Rationale
We need to consolidate our Log4j2.xml configs so that we can more easily update them
Related Pull Requests
Changes