Add custom Log4j2 ConfigurationFactory that allows Composite Log4j configuration #988
Conversation
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
Sigmonia
changed the title
|
does this result in 2 primary log4js that we need to keep in sync? will these changes also impact what we're doing with chef? ( https://github.com/LabKey/syseng-chef-server/blob/develop/cookbooks/lk_appserver/templates/default/log4j2_tc10.xml.erb ) |
Sigmonia
force-pushed
the
fb_compositeLog4j
branch
3 times, most recently
from
482b9b2 to
a7c72d4
Compare
Sigmonia
force-pushed
the
fb_compositeLog4j
branch
2 times, most recently
from
b57bb23 to
baf1277
Compare
Exclude commson-logging to remove warning
…ntainer. Switching to a different strategy.
Sigmonia
force-pushed
the
fb_compositeLog4j
branch
from
baf1277 to
794c058
Compare
|
Log configuration changes moved to the Dockerfile repo. |
labkey-willm
left a comment
labkey-willm
left a comment
There was a problem hiding this comment.
looks fine except for the added level bits, which shouldn't be necessary.
| <Logger name="org.apache.jasper" level="warn"/> | ||
|
|
||
| <Logger name="org.labkey" /> | ||
| <Logger name="org.labkey" level="info" /> |
There was a problem hiding this comment.
the <Root level="info"> above should make this (and the other two you added) moot.
There was a problem hiding this comment.
These were causing issues/errors when using the ConfigurationFactory, they don't seem to be doing so now. So I removed them.
Rationale
We need to consolidate our Log4j2.xml configs so that we can more easily update them
Related Pull Requests
Changes