fix startup error for missing config/ ; fix JSON logging format #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-stuartm
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
52974, error about " /config is a directory", due to incomplete bash test .
[ -s "config/${LOG4J_CONFIG_OVERRIDE}" ]would succeed if the var wasn't defined (because -s passes if the dir exists), but later what was supposed to be a file is only a dir, so it throws the error. Now it'll be a -f and a -s testJSON logging has been broken for a while, because our deployments should be using the
labkey.log4j2.xmlwhen JSON_OUTPUT=true, but were not.labkey.log4j2.xml also needed updating to match changes in Issue 52684: Update Log4j plugin registration server#1069
Related Pull Requests
Changes