Skip to content

Conversation

@dkarrasch
Copy link
Member

Fixes #662. Unsurprisingly, this call into LinearAlgebra was not covered by tests. The method signature of the internal method must have changed in the v1.11 cycle.

@dkarrasch dkarrasch added the backport 1.12 Change should be backported to release-1.12 label Dec 23, 2025
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.17%. Comparing base (4f25e13) to head (8555722).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   84.08%   84.17%   +0.08%     
==========================================
  Files          12       12              
  Lines        9301     9301              
==========================================
+ Hits         7821     7829       +8     
+ Misses       1480     1472       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch dkarrasch merged commit f058211 into main Dec 23, 2025
11 checks passed
@dkarrasch dkarrasch deleted the dk/fix-genericsparsedensemul branch December 23, 2025 10:40
@dkarrasch dkarrasch mentioned this pull request Dec 23, 2025
1 task
@timholy
Copy link
Contributor

timholy commented Dec 23, 2025

Thanks for the quick fix!

@dkarrasch dkarrasch added the backport 1.13 Change should be backported to release-1.13 label Dec 23, 2025
@dkarrasch dkarrasch mentioned this pull request Dec 23, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symmetric(sparse(A)) * X' yields MethodError on 1.11 and 1.12.3

3 participants