Skip to content

Fix generic sparse-dense multiplication #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkarrasch merged 1 commit into from
Dec 23, 2025
+9 −1
Merged

Fix generic sparse-dense multiplication #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Base.@constprop :aggressive function spdensemul!(C, tA, tB, A, B, alpha, beta)
T = eltype(C)
_mul!(rangefun, diagop, odiagop, C, A, B, T(alpha), T(beta))
else
@stable_muladdmul LinearAlgebra._generic_matmatmul!(C, 'N', 'N', wrap(A, tA), wrap(B, tB), MulAddMul(alpha, beta))
@stable_muladdmul LinearAlgebra._generic_matmatmul!(C, wrap(A, tA), wrap(B, tB), MulAddMul(alpha, beta))
end
return C
end
Expand Down
8 changes: 8 additions & 0 deletions test/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,14 @@ end
end
end

@testset "multiplication of special sparse with dense matrix" begin
# this results in a call of the most generic multiplication code in LinearAlgebra.jl
A = randn(2, 2)
S = sparse(A)
B = rand(1, 2)'
@test Symmetric(S) * B ≈ Symmetric(A) * B
end

@testset "sparse transpose adjoint" begin
A = sprand(10, 10, 0.75)
@test A' == SparseMatrixCSC(A')
Expand Down
Loading