Backports to release v1.13 #665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #665 +/- ##
================================================
+ Coverage 84.07% 84.18% +0.10%
================================================
Files 12 12
Lines 9300 9301 +1
================================================
+ Hits 7819 7830 +11
+ Misses 1481 1471 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mostly for `nzrange` but also added more `@inbounds` as I went through the files. All of the functions that has additional `@inbounds` either takes no user index input or have already performed explicit checks on the index (e.g. `isstored`).
…s are not present (#658) Fix #655 The tests marked broken in this PR seem to be an unfortunate regression that doesn't have to do with this PR. @jishnub This seems to have to do with methods that multiply a SparseMatrixCSC with a Diagonal and the behaviour seems right in 1.10, but not in 1.11 and 1.12. --------- Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Updated CI configuration to use actions/checkout@v6 and added macOS-15-intel for macos x86 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.