chore: version-2-make-private-packages-public #502
Conversation
🦋 Changeset detectedLatest commit: 9ad4062 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughRemoved the private flag from two packages, updated changeset config to stop ignoring the device-client package, and added a changeset documenting major version bumps and the ping JavaScript SDK v2 release. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 9ad4062
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.changeset/config.json(0 hunks).changeset/hip-owls-rule.md(1 hunks)packages/device-client/package.json(0 hunks)packages/journey-client/package.json(0 hunks)
💤 Files with no reviewable changes (3)
- .changeset/config.json
- packages/device-client/package.json
- packages/journey-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
| '@forgerock/sdk-utilities': major | ||
| --- | ||
|
|
||
| releasing version 2 of the ping javascript sdk |
There was a problem hiding this comment.
Clarify the release message scope.
The message "releasing version 2 of the ping javascript sdk" is ambiguous. Does this apply to all 13 packages, a specific package, or just the public release of previously-private packages? Consider updating the message to match the actual scope and purpose of this release.
🤖 Prompt for AI Agents
In .changeset/hip-owls-rule.md around line 16, the release note "releasing
version 2 of the ping javascript sdk" is ambiguous; update it to explicitly
state the scope and purpose (e.g., list the affected package names or say "all
13 packages" or "public release of previously-private packages"), include the
new version number(s), and a short rationale or breaking-change note if
applicable so the changelog accurately reflects which packages are being
released and why.
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Important
Nx Cloud has identified a possible root cause for your failed CI:
We've confirmed this test failure exists identically in the main branch and is unrelated to our package publishing changes. The PR only modifies package.json visibility settings, which have no impact on the middleware E2E test logic or authentication flows.
No code changes were suggested for this issue.
🎓 Learn more about Self-Healing CI on nx.dev
|
Failing because it is dependent on #501 password changes |
ryanbas21
force-pushed
the
update-for-major-release
branch
from
9dc439e to
9ad4062
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (18.81%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 18.79% 18.81% +0.02%
==========================================
Files 140 140
Lines 27640 27647 +7
Branches 980 981 +1
==========================================
+ Hits 5195 5202 +7
Misses 22445 22445 🚀 New features to boost your workflow:
|
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed d7af5fe to https://ForgeRock.github.io/ping-javascript-sdk/pr-502/d7af5fe91d6a5f97f5bea814a9937fae43ff3969 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-82.4 KB, -100.0%) 📊 Minor Changes📈 @forgerock/journey-client - 82.4 KB (+0.1 KB) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4046
Description
Note: I'm really unsure of what to put in this changeset. We probably can delete this changeset in the future. It may be the best way to go about it.
This PR just marks private packages under packages/* like device client and journey client as public.
The rest of the packages were marked as major changes but obviously there are no changes.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.