Skip to content

Conversation

@ryanbas21
Copy link
Collaborator

@ryanbas21 ryanbas21 commented Dec 10, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@forgerock/davinci-client@2.0.0

Major Changes

Patch Changes

  • Updated dependencies [9ad4062]:
    • @forgerock/sdk-logger@2.0.0
    • @forgerock/sdk-oidc@2.0.0
    • @forgerock/sdk-request-middleware@2.0.0
    • @forgerock/storage@2.0.0
    • @forgerock/sdk-types@2.0.0

@forgerock/device-client@2.0.0

Major Changes

@forgerock/journey-client@2.0.0

Major Changes

Patch Changes

  • #500 e99b374 Thanks @ancheetah! - Add support for KBA allowUserDefinedQuestions flag

  • Updated dependencies [9ad4062]:

    • @forgerock/sdk-logger@2.0.0
    • @forgerock/sdk-request-middleware@2.0.0
    • @forgerock/storage@2.0.0
    • @forgerock/sdk-types@2.0.0
    • @forgerock/sdk-utilities@2.0.0

@forgerock/oidc-client@2.0.0

Major Changes

Patch Changes

  • Updated dependencies [9ad4062]:
    • @forgerock/iframe-manager@2.0.0
    • @forgerock/sdk-logger@2.0.0
    • @forgerock/sdk-oidc@2.0.0
    • @forgerock/sdk-request-middleware@2.0.0
    • @forgerock/storage@2.0.0
    • @forgerock/sdk-types@2.0.0

@forgerock/protect@2.0.0

Major Changes

@forgerock/iframe-manager@2.0.0

Major Changes

@forgerock/sdk-logger@2.0.0

Major Changes

@forgerock/sdk-oidc@2.0.0

Major Changes

Patch Changes

  • Updated dependencies [9ad4062]:
    • @forgerock/sdk-types@2.0.0
    • @forgerock/sdk-utilities@2.0.0

@forgerock/sdk-request-middleware@2.0.0

Major Changes

@forgerock/storage@2.0.0

Major Changes

Patch Changes

  • Updated dependencies [9ad4062]:
    • @forgerock/sdk-types@2.0.0

@forgerock/sdk-types@2.0.0

Major Changes

@forgerock/sdk-utilities@2.0.0

Major Changes

Summary by CodeRabbit

  • New Features

    • Added support for KBA allowUserDefinedQuestions flag in journey-client.
  • Releases

    • Released version 2.0.0 across all SDK packages (davinci-client, journey-client, oidc-client, protect, sdk-effects modules, sdk-types, sdk-utilities, and device-client).
    • Updated dependencies across packages to align with version 2.0.0 release.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Walkthrough

Bumps package versions from 1.3.0 to 2.0.0 across many packages, inserts new 2.0.0 entries into multiple CHANGELOG.md files, and removes a single changeset file .changeset/eleven-baboons-battle.md. No code or behavioral changes detected.

Changes

Cohort / File(s) Summary
Changeset removal
.changeset/eleven-baboons-battle.md
Deleted a changeset entry that documented KBA allowUserDefinedQuestions flag support.
Top-level clients & products
packages/davinci-client/package.json, packages/davinci-client/CHANGELOG.md, packages/journey-client/package.json, packages/journey-client/CHANGELOG.md, packages/oidc-client/package.json, packages/oidc-client/CHANGELOG.md, packages/protect/package.json, packages/protect/CHANGELOG.md, packages/device-client/package.json, packages/device-client/CHANGELOG.md
Version fields bumped from 1.3.0 to 2.0.0; new ## 2.0.0 sections added to respective CHANGELOGs (Major/Patch entries recorded). No functional changes.
SDK effects packages
packages/sdk-effects/iframe-manager/package.json, packages/sdk-effects/iframe-manager/CHANGELOG.md, packages/sdk-effects/logger/package.json, packages/sdk-effects/logger/CHANGELOG.md, packages/sdk-effects/oidc/package.json, packages/sdk-effects/oidc/CHANGELOG.md, packages/sdk-effects/sdk-request-middleware/package.json, packages/sdk-effects/sdk-request-middleware/CHANGELOG.md, packages/sdk-effects/storage/package.json, packages/sdk-effects/storage/CHANGELOG.md
Version bumps to 2.0.0 and new changelog entries added (PR references and dependency updates). No code changes.
SDK foundation packages
packages/sdk-types/package.json, packages/sdk-types/CHANGELOG.md, packages/sdk-utilities/package.json, packages/sdk-utilities/CHANGELOG.md, packages/sdk-effects/logger/package.json*
Version bumps to 2.0.0 and added 2.0.0 changelog entries; public API and source code unchanged.
Misc manifest updates
packages/device-client/package.json, packages/journey-client/package.json, packages/protect/package.json, packages/oidc-client/package.json, packages/sdk-effects/storage/package.json, packages/sdk-effects/iframe-manager/package.json, packages/sdk-effects/oidc/package.json, packages/sdk-effects/sdk-request-middleware/package.json, packages/sdk-effects/logger/package.json, packages/sdk-types/package.json, packages/sdk-utilities/package.json, packages/davinci-client/package.json
All listed package.json files updated: version changed from 1.3.0 (or 0.0.1 for device-client) to 2.0.0. No other manifest fields modified.

*Note: packages/sdk-effects/logger/package.json appears in both SDK effects and foundation groups due to overlapping categorization of effects/logger.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Rationale: Many files touched but changes are highly repetitive (version and changelog text); review focuses on consistency and accidental edits.
  • Areas to spot-check:
    • Consistent version numbers across all package.json files and no unintended script/dependency changes.
    • CHANGELOG formatting and correct placement of new 2.0.0 entries.
    • Ensure deletion of .changeset/eleven-baboons-battle.md is intentional (no remaining references).

Possibly related PRs

Suggested reviewers

  • ryanbas21
  • spetrov
  • cerebrl

Poem

🐇 I hopped through files with tiny feet,

Bumped each version to make release neat.
Changelogs stacked, a tidy queue,
Deleted one note — who knew? — just a few.
🥕 Cheers from the rabbit for version two!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Release PR' is vague and generic, failing to convey the specific nature or scope of the release (major version bump to 2.0.0 across multiple packages). Improve the title to be more descriptive, such as 'Release version 2.0.0 of all packages' or 'Bump all packages to v2.0.0'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes auto-generated release notes from Changesets but lacks JIRA ticket reference and lacks explicit description of changes; it relies on boilerplate Changesets action text.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch changeset-release/main

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8753b12 and 2361b54.

📒 Files selected for processing (25)
  • .changeset/eleven-baboons-battle.md (0 hunks)
  • packages/davinci-client/CHANGELOG.md (1 hunks)
  • packages/davinci-client/package.json (1 hunks)
  • packages/device-client/CHANGELOG.md (1 hunks)
  • packages/device-client/package.json (1 hunks)
  • packages/journey-client/CHANGELOG.md (1 hunks)
  • packages/journey-client/package.json (1 hunks)
  • packages/oidc-client/CHANGELOG.md (1 hunks)
  • packages/oidc-client/package.json (1 hunks)
  • packages/protect/CHANGELOG.md (1 hunks)
  • packages/protect/package.json (1 hunks)
  • packages/sdk-effects/iframe-manager/CHANGELOG.md (1 hunks)
  • packages/sdk-effects/iframe-manager/package.json (1 hunks)
  • packages/sdk-effects/logger/CHANGELOG.md (1 hunks)
  • packages/sdk-effects/logger/package.json (1 hunks)
  • packages/sdk-effects/oidc/CHANGELOG.md (1 hunks)
  • packages/sdk-effects/oidc/package.json (1 hunks)
  • packages/sdk-effects/sdk-request-middleware/CHANGELOG.md (1 hunks)
  • packages/sdk-effects/sdk-request-middleware/package.json (1 hunks)
  • packages/sdk-effects/storage/CHANGELOG.md (1 hunks)
  • packages/sdk-effects/storage/package.json (1 hunks)
  • packages/sdk-types/CHANGELOG.md (1 hunks)
  • packages/sdk-types/package.json (1 hunks)
  • packages/sdk-utilities/CHANGELOG.md (1 hunks)
  • packages/sdk-utilities/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/eleven-baboons-battle.md
✅ Files skipped from review due to trivial changes (3)
  • packages/protect/CHANGELOG.md
  • packages/oidc-client/package.json
  • packages/device-client/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (8)
  • packages/sdk-utilities/package.json
  • packages/davinci-client/package.json
  • packages/journey-client/package.json
  • packages/sdk-effects/iframe-manager/CHANGELOG.md
  • packages/sdk-effects/logger/CHANGELOG.md
  • packages/sdk-effects/sdk-request-middleware/package.json
  • packages/sdk-effects/oidc/package.json
  • packages/sdk-effects/oidc/CHANGELOG.md
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-22T15:14:00.044Z
Learnt from: ryanbas21
Repo: ForgeRock/ping-javascript-sdk PR: 430
File: packages/journey-client/src/lib/callbacks/name-callback.ts:9-15
Timestamp: 2025-10-22T15:14:00.044Z
Learning: In packages/journey-client, callback classes are internal implementation details not part of the public API. The callbacks barrel (src/lib/callbacks/index.ts) intentionally only exports the base JourneyCallback class. Internal code imports concrete callback classes directly from their individual files (e.g., factory.ts, journey-client.ts).

Applied to files:

  • packages/journey-client/CHANGELOG.md
📚 Learning: 2025-09-23T20:50:26.537Z
Learnt from: ancheetah
Repo: ForgeRock/ping-javascript-sdk PR: 417
File: packages/sdk-effects/storage/src/lib/storage.effects.ts:11-12
Timestamp: 2025-09-23T20:50:26.537Z
Learning: When the storage client API was changed from returning void to GenericError | null in SDKS-4361, call sites in DaVinci client and OIDC client were not updated to handle the returned errors, creating a follow-up task for proper error handling implementation.

Applied to files:

  • packages/davinci-client/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: pr
🔇 Additional comments (13)
packages/sdk-effects/iframe-manager/package.json (1)

3-3: Version bump aligns with coordinated 2.0.0 release.

The version is correctly bumped from 1.3.0 to 2.0.0, consistent with the PR objectives showing @forgerock/iframe-manager@2.0.0 in the coordinated release across all ForgeRock SDK packages.

packages/sdk-utilities/CHANGELOG.md (1)

3-8: Changelog entry for v2.0.0 is correctly formatted and complete.

The new 2.0.0 section follows the established Changesets convention, includes proper PR/commit references, contributor attribution, and a clear release note. The entry integrates cleanly with existing changelog sections.

packages/davinci-client/CHANGELOG.md (1)

3-16: Changelog entry correctly formatted and complete.

The new 2.0.0 entry follows the standard Changesets format with Major and Patch Changes sections. All five dependency updates are correctly listed at version 2.0.0, matching the release scope outlined in the PR objectives. The entry references the expected commit and PR number.

packages/sdk-effects/sdk-request-middleware/CHANGELOG.md (1)

3-7: LGTM!

The 2.0.0 changelog entry is properly formatted with correct PR reference, commit hash, author attribution, and clear messaging. This is an appropriate auto-generated entry from the Changesets release action.

packages/protect/package.json (1)

3-3: Version bump to 2.0.0 looks correct.

The version update from 1.3.0 to 2.0.0 is appropriate for the major release. No dependency updates are needed for this package (consistent with PR objectives), and all other configuration remains unchanged.

packages/sdk-types/CHANGELOG.md (1)

3-8: LGTM!

The new 2.0.0 changelog entry is properly formatted and consistent with existing entries in the file. The reference to PR #502 with commit hash and author attribution is correctly structured, and the version entry is appropriately positioned at the top of the changelog.

packages/journey-client/CHANGELOG.md (1)

3-18: Changelog correctly documents the 2.0.0 release.

The new section accurately records both the major version release (PR #502) and the KBA allowUserDefinedQuestions flag support (PR #500), with all dependency updates properly listed at 2.0.0. The formatting is clean and consistent with the established changelog structure.

packages/sdk-types/package.json (1)

3-3: Version bump correctly applied.

The version has been updated from 1.3.0 to 2.0.0 as expected for the major release. No dependency or API changes detected.

packages/device-client/package.json (1)

3-3: Version bump correctly applied for major release.

Updated from 0.0.1 to 2.0.0, aligning with the major release of the ping JavaScript SDK. Dependencies remain unchanged.

packages/sdk-effects/logger/package.json (1)

3-3: Version bump correctly applied.

Updated from 1.3.0 to 2.0.0 for the major release. No dependency or API changes.

packages/sdk-effects/storage/package.json (1)

3-3: Version bump correctly applied.

Updated from 1.3.0 to 2.0.0. Workspace reference to sdk-types is properly maintained.

packages/sdk-effects/storage/CHANGELOG.md (1)

3-13: Changelog entry properly formatted and aligned with release.

The 2.0.0 entry is correctly structured with Major Changes (PR #502) and Patch Changes reflecting the dependency update to @forgerock/sdk-types@2.0.0. Previous versions are preserved for historical context.

packages/oidc-client/CHANGELOG.md (1)

3-17: Changelog entry correctly generated and aligned with PR objectives.

The new 2.0.0 section has been created by Changesets and includes all expected content. The major version release note references PR #502 with the correct commit hash (9ad4062), and all six updated dependencies are properly listed at version 2.0.0, matching the PR release objectives. The formatting is consistent with the existing 1.3.0 section and follows standard Changesets conventions.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Dec 10, 2025

View your CI Pipeline Execution ↗ for commit 2361b54

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded <1s View ↗
nx affected -t build lint test e2e-ci ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-10 21:53:08 UTC

nx-cloud[bot]

This comment was marked as outdated.

@ryanbas21 ryanbas21 force-pushed the changeset-release/main branch from 8753b12 to d58c175 Compare December 10, 2025 21:46
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we reran your CI automatically.

Nx Cloud View detailed reasoning in Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@506

@forgerock/device-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/device-client@506

@forgerock/journey-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/journey-client@506

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@506

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@506

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@506

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@506

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@506

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@506

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@506

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@506

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@506

commit: 2361b54

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.81%. Comparing base (b89ad58) to head (2361b54).
⚠️ Report is 17 commits behind head on main.

❌ Your project status has failed because the head coverage (18.81%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   18.79%   18.81%   +0.02%     
==========================================
  Files         140      140              
  Lines       27640    27647       +7     
  Branches      980      981       +1     
==========================================
+ Hits         5195     5202       +7     
  Misses      22445    22445              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Deployed 2b0a825 to https://ForgeRock.github.io/ping-javascript-sdk/pr-506/2b0a825301639b274da5ac569f6e2e9491ba1729 branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions
Copy link
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/journey-client - 0.0 KB (-82.4 KB, -100.0%)

➖ No Changes

@forgerock/device-client - 9.2 KB
@forgerock/oidc-client - 23.4 KB
@forgerock/protect - 150.1 KB
@forgerock/sdk-utilities - 7.5 KB
@forgerock/journey-client - 82.4 KB
@forgerock/sdk-types - 8.0 KB
@forgerock/storage - 1.4 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/sdk-request-middleware - 4.5 KB
@forgerock/sdk-oidc - 2.6 KB
@forgerock/davinci-client - 39.5 KB


13 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants