Skip to content

chore: version-2-make-private-packages-public #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbas21 merged 1 commit into from
Dec 10, 2025
Merged

chore: version-2-make-private-packages-public #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"ignore": [
"scratchpad",
"@forgerock/pingone-scripts",
"@forgerock/device-client",
"@forgerock/device-client-app",
"@forgerock/davinci-app",
"@forgerock/davinci-suites",
Expand Down
16 changes: 16 additions & 0 deletions .changeset/hip-owls-rule.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
'@forgerock/journey-client': major
'@forgerock/device-client': major
'@forgerock/davinci-client': major
'@forgerock/oidc-client': major
'@forgerock/protect': major
'@forgerock/iframe-manager': major
'@forgerock/sdk-logger': major
'@forgerock/sdk-oidc': major
'@forgerock/sdk-request-middleware': major
'@forgerock/storage': major
'@forgerock/sdk-types': major
'@forgerock/sdk-utilities': major
---

releasing version 2 of the ping javascript sdk
Copy link

@coderabbitai coderabbitai bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Clarify the release message scope.

The message "releasing version 2 of the ping javascript sdk" is ambiguous. Does this apply to all 13 packages, a specific package, or just the public release of previously-private packages? Consider updating the message to match the actual scope and purpose of this release.

🤖 Prompt for AI Agents 
In .changeset/hip-owls-rule.md around line 16, the release note "releasing
version 2 of the ping javascript sdk" is ambiguous; update it to explicitly
state the scope and purpose (e.g., list the affected package names or say "all
13 packages" or "public release of previously-private packages"), include the
new version number(s), and a short rationale or breaking-change note if
applicable so the changelog accurately reflects which packages are being
released and why.

1 change: 0 additions & 1 deletion packages/device-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@forgerock/device-client",
"version": "0.0.1",
"private": true,
"repository": {
"type": "git",
"url": "git+https://github.com/ForgeRock/ping-javascript-sdk.git",
Expand Down
1 change: 0 additions & 1 deletion packages/journey-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@forgerock/journey-client",
"version": "1.3.0",
"private": true,
"type": "module",
"exports": {
".": "./dist/src/index.js",
Expand Down
Loading