Add missing item.preview.* i18n keys + ensure consistency with existing i18n patterns#5149
Add missing item.preview.* i18n keys + ensure consistency with existing i18n patterns#5149MMilosz wants to merge 2 commits intoDSpace:mainfrom
item.preview.* i18n keys + ensure consistency with existing i18n patterns#5149Conversation
- Extracted strings from `<constructor-arg value=".*"` in [dspace-source-backend]/dspace/config/spring/api/*-integration.xml - Compared against existing keys in [dspace-source-frontend]/src/assets/i18n/en.json5 See DSpace/DSpace#5148 for details
- standardize all item.preview.* labels with colons & Title Case Capitalization & singular/plural forms for consistency
- move item.preview.organization.url & item.preview.organization.address.{addressLocality,legalName} closer to other item.preview.organization.*
- change 'Published date' -> 'Publication Date' for consistent '[Action] Date' format
- change 'Acronym' -> 'Alternative Names:' for consistency with the metadatum field name: dc.title.alternative
- remove duplicates
| "item.preview.dc.identifier.isbn": "ISBN", | ||
| "item.preview.dc.identifier.isni": "ISNI:", | ||
|
|
||
| "item.preview.dc.identifier.mag": "Microsoft Academic Graph (MAG) ID:", |
There was a problem hiding this comment.
Note: Unsure if this should stay as MAG:, MAG ID:, MAG Identifier:, or Microsoft Academic Graph (MAG) ID:
|
|
||
| "item.preview.dc.identifier.mag": "Microsoft Academic Graph (MAG) ID:", | ||
|
|
||
| "item.preview.dc.identifier.rid": "ResearcherID (RID):", |
There was a problem hiding this comment.
Note: Unsure if this should stay as RID:, ResearcherID:, or ResearcherID (RID):
| "item.preview.dc.title.alternative": "Acronym:", | ||
| "item.preview.oaire.awardURI": "Award URI:", | ||
|
|
||
| "item.preview.dc.title.alternative": "Alternative Names:", |
There was a problem hiding this comment.
Note: the change Acronym: -> Alternative Names: is to better reflect that it uses the dc.title.alternative metadatum (NOT dc.title.abbreviated)
| "item.preview.oaire.citation.volume": "Volume:", | ||
|
|
||
| "item.preview.oaire.citation.volume": "Volume", | ||
| "item.preview.oaire.citation.title": "Citation Container:", |
There was a problem hiding this comment.
Note: Unsure if Citation Container: is understandable. What about... Source Title, Appears In, Parent Title, Source Work, Journal/Book Title?
Per oaire:citationTitle definition:
The title name of the container (e.g. journal, book, conference) this work is published in. This property is considered to be part of the bibliographic citation.
[...]
24.3. Example
oaire:citationTitlesome Journal Title</oaire:citationTitle>
| "item.preview.oairecerif.funding.startDate": "Funding Start Date:", | ||
|
|
||
| "item.preview.organization.identifier.ror": "ROR ID", | ||
| "item.preview.oairecerif.fundingParent": "Funding Program:", |
There was a problem hiding this comment.
Note: I couldn't find any details in OpenAIRE docs regarding this field... however, I found one DSpace instance that uses this translation [source]
1 participant
References
Description
Adds missing
item.preview.*translations for metadata fields in the Publication Preview section, ensuring consistency with existing i18n patterns.Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.