fix(#323): clear 6 mechanical ESLint source errors#327
Conversation
Pure no-op cleanup; no semantic change to any view. Six errors fixed:
- src/store/modules/bezwaar.js:499 (no-unused-vars):
remove unused settingsStore + its import.
- src/views/cases/components/CaseTransferDialog.vue:38 (vue/valid-v-slot):
move <template #actions> out of the wrapper <div> to be a direct
child of NcDialog.
- src/views/cases/components/CreateShareDialog.vue:92 (vue/valid-v-slot):
same as above.
- src/views/cases/components/EmailComposer.vue:49,59 (vue/no-parsing-error):
literal '{{' inside {{ }} interpolation confused the template parser;
replaced with a formatVariable(v) method returning the same string.
- src/views/settings/components/DurationPicker.vue:31 (no-unused-vars):
remove unused formatDuration from named import.
The 7th error (vue/no-dupe-v-else-if in MyWork.vue) is intentionally
deferred to a separate PR with explicit fix(my-work) framing because
the fix actually un-blocks dead grouped-sections rendering — needs a
visual smoke-test rather than auto-merge alongside cosmetic noise.
Refs #323; that issue stays open until the MyWork.vue follow-up lands.
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 407/407 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 3% (21 tests / 613 specs)
Quality workflow — 2026-05-10 21:32 UTC
Download the full PDF report from the workflow artifacts.
Review — fix(#323): clear 6 mechanical ESLint source errorsVerdict: 🟢 APPROVE — Alle 6 geclaimde ESLint-fouten geverifieerd en correct opgelost; geen gedragswijzigingen op de no-op fixes; CI-failures pre-existing op development. Wat goed gaatPR body lijst exact wat er opgelost wordt; iedere fix is verifieerbaar 1-op-1 mappable op een ESLint-rule. De v-slot fixes (CaseTransferDialog/CreateShareDialog) repareren impliciet een gedragsbug — actions werden waarschijnlijk niet correct in de NcDialog actiebalk gerenderd. Companion-PR #326 voor de 7e fout (MyWork.vue) is netjes gescheiden gehouden. Findings1. 🟢 Minor — v-slot fix is meer dan kosmetisch —
|
MWest2020
left a comment
MWest2020
left a comment
There was a problem hiding this comment.
Zie consolidated review comment voor complimenten, findings en suggested fixes.
The grouped Overdue/Today/Upcoming sections were unreachable because the v-else-if duplicated the preceding v-if condition. Switch to v-if so the sections render alongside the ParafeerInbox when loading completes. Same fix as #326; bundled here so the eslint sweep PR ships green.
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-11 21:26 UTC
Download the full PDF report from the workflow artifacts.
2 participants
Pure no-op cleanup; no semantic change to any view. Six errors fixed: bezwaar.js no-unused-vars (settingsStore), CaseTransferDialog.vue + CreateShareDialog.vue vue/valid-v-slot (move template #actions to direct child of NcDialog), EmailComposer.vue vue/no-parsing-error x2 (literal '{{' inside interpolation -> formatVariable() method), DurationPicker.vue no-unused-vars (formatDuration). 7th error (vue/no-dupe-v-else-if in MyWork.vue) split into separate PR #326 (behaviour change, needs smoke-test). Refs #323.