fix(my-work): un-block grouped Overdue/Today/Upcoming sections#326
fix(my-work): un-block grouped Overdue/Today/Upcoming sections#326rubenvdlinde wants to merge 1 commit into
Conversation
src/views/MyWork.vue had a dead branch `v-else-if="!loading"` that could never execute — `v-else-if` only fires when the previous sibling's condition is false, but the sibling chain fell through ParafeerInbox to a guard that always rendered. Result: the grouped Overdue / Today / Upcoming sections of the My Work view never rendered in production. Git history (commit 5847d05) shows those sections were the original intent — the typo'd `v-else-if` slipped in when ParafeerInbox was inserted into the chain. Changing the directive to `v-if="!loading"` makes the grouped sections render alongside ParafeerInbox per the original design. This is a behaviour change (visible UI difference). A manual smoke-test of /procest's My Work view post-merge confirms whether the restored sections look right vs the regressed state. Surfaced by #323 ESLint sweep (vue/no-dupe-v-else-if). Companion PR fix(#323): clear 6 mechanical ESLint source errors handles the other 6 cosmetic fixes.
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 407/407 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 3% (21 tests / 613 specs)
Quality workflow — 2026-05-10 21:31 UTC
Download the full PDF report from the workflow artifacts.
Review — fix(my-work): un-block grouped Overdue/Today/Upcoming sectionsVerdict: 🟢 APPROVE — One-liner fix is correct en voldoende; v-else-if naar v-if herstelt de grouped sections; CI-failures (incl. Playwright) zijn allemaal pre-existing op development (bevestigd via procest#327 review). Wat goed gaatUitstekende commit message met root-cause analyse + verwijzing naar de originele commit (5847d05) waar het bedoelde gedrag bestond. De fix is minimaal en chirurgisch: één teken wijziging ( Findings1. 🟡 Concern — Smoke-test handmatig — geen Playwright-spec voor de grouped sections —
|
MWest2020
left a comment
MWest2020
left a comment
There was a problem hiding this comment.
Zie consolidated review comment voor complimenten, findings en suggested fixes.
The grouped Overdue/Today/Upcoming sections were unreachable because the v-else-if duplicated the preceding v-if condition. Switch to v-if so the sections render alongside the ParafeerInbox when loading completes. Same fix as #326; bundled here so the eslint sweep PR ships green.
|
Superseded by #327 — same single-line MyWork.vue fix ( |
2 participants
Behaviour change — needs smoke-test. src/views/MyWork.vue had a dead v-else-if branch that prevented Overdue/Today/Upcoming sections from rendering. Git history (commit 5847d05) shows those sections were the original intent. Companion to fix/323-mechanical-eslint-fixes (cosmetic-only PR). Smoke-test: load /apps/procest's My Work view; confirm grouped sections render alongside ParafeerInbox.