Skip to content

fix(#323): clear 6 mechanical ESLint source errors #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubenvdlinde wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix(#323): clear 6 mechanical ESLint source errors #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bab8f7
fix(#323): clear 6 mechanical ESLint source errors
rubenvdlinde May 10, 2026
11795ea
fix(my-work): un-block grouped sections (subsume #326)
rubenvdlinde May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/store/modules/bezwaar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
*/
import { defineStore } from 'pinia'
import { useObjectStore } from './object.js'
import { useSettingsStore } from './settings.js'

/**
* Add working days to a date (skipping weekends).
Expand Down Expand Up @@ -496,7 +495,6 @@ export const useBezwaarStore = defineStore('bezwaar', {

try {
const objectStore = useObjectStore()
const settingsStore = useSettingsStore()

// Find the Beroep case type.
const caseTypes = await objectStore.fetchCollection('caseType', {
Expand Down
2 changes: 1 addition & 1 deletion src/views/MyWork.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<ParafeerInbox v-if="!loading" />

<!-- Grouped sections -->
<template v-else-if="!loading">
<template v-if="!loading">
<!-- Overdue -->
<div v-if="filteredGroups.overdue.length > 0" class="my-work__section my-work__section--overdue">
<h3 class="my-work__section-header my-work__section-header--overdue">
Expand Down Expand Up @@ -329,7 +329,7 @@
async fetchData() {
this.loading = true
try {
const currentUser = OC?.currentUser || ''

Check warning on line 332 in src/views/MyWork.vue

View workflow job for this annotation

GitHub Actions / quality / Vue Quality (eslint) 

The property or function OC.currentUser was deprecated in Nextcloud 19.0.0

// Fetch case types for name resolution.
const caseTypes = await this.objectStore.fetchCollection('caseType', { _limit: 100 })
Expand Down Expand Up @@ -367,7 +367,7 @@
}

try {
const currentUser = OC?.currentUser || ''

Check warning on line 370 in src/views/MyWork.vue

View workflow job for this annotation

GitHub Actions / quality / Vue Quality (eslint) 

The property or function OC.currentUser was deprecated in Nextcloud 19.0.0

// Find final status IDs by fetching statusTypes with isFinal.
const statusTypes = await this.objectStore.fetchCollection('statusType', { _limit: 200 })
Expand Down
24 changes: 12 additions & 12 deletions src/views/cases/components/CaseTransferDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,19 @@
v-model="form.requestedDate"
type="date" />
</div>

<template #actions>
<NcButton @click="$emit('update:open', false)">
{{ t('procest', 'Cancel') }}
</NcButton>
<NcButton
type="primary"
:disabled="!isValid || saving"
@click="submitTransfer">
{{ saving ? t('procest', 'Submitting...') : t('procest', 'Submit transfer request') }}
</NcButton>
</template>
</div>

<template #actions>
<NcButton @click="$emit('update:open', false)">
{{ t('procest', 'Cancel') }}
</NcButton>
<NcButton
type="primary"
:disabled="!isValid || saving"
@click="submitTransfer">
{{ saving ? t('procest', 'Submitting...') : t('procest', 'Submit transfer request') }}
</NcButton>
</template>
</NcDialog>
</template>

Expand Down
24 changes: 12 additions & 12 deletions src/views/cases/components/CreateShareDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,19 @@
</NcButton>
</div>
</div>

<template #actions>
<NcButton @click="$emit('update:open', false)">
{{ t('procest', 'Cancel') }}
</NcButton>
<NcButton
type="primary"
:disabled="saving"
@click="createShare">
{{ saving ? t('procest', 'Creating...') : t('procest', 'Create share') }}
</NcButton>
</template>
</div>

<template #actions>
<NcButton @click="$emit('update:open', false)">
{{ t('procest', 'Cancel') }}
</NcButton>
<NcButton
type="primary"
:disabled="saving"
@click="createShare">
{{ saving ? t('procest', 'Creating...') : t('procest', 'Create share') }}
</NcButton>
</template>
</NcDialog>
</template>

Expand Down
7 changes: 5 additions & 2 deletions src/views/cases/components/EmailComposer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<div v-if="unresolvedVars.length > 0" class="email-composer__warning">
{{ t('procest', 'Unresolved variables:') }}
<span v-for="v in unresolvedVars" :key="v" class="email-composer__unresolved">
{{ '{{' + v + '}}' }}
{{ formatVariable(v) }}
</span>
</div>

Expand All @@ -56,7 +56,7 @@
<summary>{{ t('procest', 'Available variables') }}</summary>
<div class="email-composer__variable-list">
<code v-for="v in availableVariables" :key="v" @click="insertVariable(v)">
{{ '{{' + v + '}}' }}
{{ formatVariable(v) }}
</code>
</div>
</details>
Expand Down Expand Up @@ -87,7 +87,7 @@
<h5>{{ t('procest', 'Email Preview') }}</h5>
<p><strong>{{ t('procest', 'To:') }}</strong> {{ form.to }}</p>
<p><strong>{{ t('procest', 'Subject:') }}</strong> {{ previewSubject }}</p>
<div class="email-composer__preview-body" v-html="previewBody" />

Check warning on line 90 in src/views/cases/components/EmailComposer.vue

View workflow job for this annotation

GitHub Actions / quality / Vue Quality (eslint) 

'v-html' directive can lead to XSS attack
<NcButton @click="showPreview = false">
{{ t('procest', 'Close') }}
</NcButton>
Expand Down Expand Up @@ -163,6 +163,9 @@
},
},
methods: {
formatVariable(varName) {
return '{{' + varName + '}}'
},
onTemplateSelected(template) {
if (!template) return
this.form.subject = template.subjectPattern || ''
Expand Down
2 changes: 1 addition & 1 deletion src/views/settings/components/DurationPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

<script>
import { NcTextField } from '@nextcloud/vue'
import { parseDuration, formatDuration, isValidDuration } from '../../../utils/durationHelpers.js'
import { parseDuration, isValidDuration } from '../../../utils/durationHelpers.js'

export default {
name: 'DurationPicker',
Expand Down
Loading