feat: disable slashing of committee during escapehatch #19307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
force-pushed
the
lh/escape-hatch-v1
branch
from
958e83c to
e13db60
Compare
LHerskind
force-pushed
the
lh/tmnt-469-tally-slashing-integration
branch
from
3bed8b4 to
7f2e17d
Compare
AztecBot
force-pushed
the
lh/escape-hatch-v1
branch
2 times, most recently
from
f4571c6 to
4e366a9
Compare
LHerskind
force-pushed
the
lh/tmnt-469-tally-slashing-integration
branch
from
7f2e17d to
900ed15
Compare
spalladino
approved these changes
Jan 6, 2026
Contributor
spalladino
left a comment
spalladino
left a comment
There was a problem hiding this comment.
Looks simple enough, great!
| Epoch protectedEpoch = slashingProposer.getSlashTargetEpoch(currentRound, 1); | ||
| uint256 protectedHatch = Epoch.unwrap(protectedEpoch) / ESCAPE_FREQUENCY; | ||
| address proposer = open ? address(0xBEEF) : address(0); | ||
| stdstore.target(address(escapeHatch)).sig("getDesignatedProposer(uint256)").with_key(protectedHatch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the slashing is unaware of the escape hatch, it is possible to slash the committee that should have been active during the hatch, even though it was not possible for them to be active. This can be mitigate in a few manners;
voteAt first I had created using approach 1, since that is really simple to understand and there is no "weirdness" in the storage not being used. But I'm leaning more to approach 2 because that is cheaper, so will be doing that.