-
Notifications
You must be signed in to change notification settings - Fork 583
feat: Escape hatch #18811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Escape hatch #18811
Conversation
48927ff to
f9647c2
Compare
1eed168 to
d2b63f1
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c7d9c7c to
f384271
Compare
| // ============ Immutables ============ | ||
|
|
||
| IInstance internal immutable ROLLUP; | ||
| uint256 internal immutable LAG_IN_HATCHES; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to give these values a comment, or add another line at the top comment. I'm mainly looking at LAG_IN_HATCHES and PROPOSING_EXIT_DELAY
just-mitch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work. Beautiful tests.
f384271 to
d0dc00e
Compare
80399a5 to
c9cada9
Compare
c9cada9 to
ee146c8
Compare
d0dc00e to
958e83c
Compare
958e83c to
e13db60
Compare
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
e13db60 to
f4571c6
Compare
An in progress escape hatch.
f4571c6 to
4e366a9
Compare

An in progress escape hatch.