refactor!: expanding return value of getLogsByTags #19233
+237
−399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
47bce0f to
6e01080
Compare
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
371a484 to
1ecae46
Compare
benesjan
changed the base branch from
12-18-feat_integrating_new_log_sync
to
graphite-base/19233
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
1ecae46 to
ec04be9
Compare
benesjan
changed the base branch from
graphite-base/19233
to
12-18-feat_integrating_new_log_sync
benesjan
added
the
ci-no-fail-fast
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
6a3088c to
7912feb
Compare
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
ec04be9 to
6b89008
Compare
benesjan
changed the title
benesjan
commented
Dec 24, 2025
| ### [AVM] Gas cost multipliers for public execution to reach simulation/proving parity | ||
|
|
||
| Gas costs for several AVM opcodes have been adjusted with multipliers to better align public simulation costs with actual proving costs. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Just run formatting below.
benesjan
commented
Dec 24, 2025
| * @param block - The L2 block to extract logs from. | ||
| * @returns An object containing the private and public tagged logs for the block. | ||
| */ | ||
| async #extractTaggedLogsFromBlock(block: L2BlockNew) { |
Contributor
Author
There was a problem hiding this comment.
blockHash was dropped from TxScopedL2Log which results in this no longer needing to be async.
benesjan
commented
Dec 24, 2025
| txEffect.data.noteHashes, | ||
| txEffect.data.nullifiers[0], | ||
| scopedLog.noteHashes, | ||
| scopedLog.firstNullifier, |
benesjan
commented
Dec 24, 2025
| }); | ||
| }); | ||
|
|
||
| describe('getPublicLogByTag', () => { |
Contributor
Author
There was a problem hiding this comment.
I made the getPublicLogByTag function private in the log service and it got greatly simplified by this PR that I don't think we need these tests anymore.
benesjan
commented
Dec 24, 2025
|
|
||
| // TODO(F-231): delete this function and implement this behavior in the node instead | ||
| public async getPublicLogByTag(tag: Tag, contractAddress: AztecAddress): Promise<PublicLogWithTxData | null> { | ||
| async #getPublicLogByTag(tag: Tag, contractAddress: AztecAddress): Promise<PublicLogWithTxData | null> { |
Contributor
Author
There was a problem hiding this comment.
This function getPrivateLogByTag were not used out of the LogService so I made them private.
I think eventually we might want to drop these functions but kept them around for no due to the linked issue #11627 below.
benesjan
commented
Dec 24, 2025
| } = {}): Promise<TxEffect> { | ||
| const count = (max: number, num?: number) => num ?? Math.min(maxEffects ?? randomInt(max), max); | ||
| // Every tx effect must have at least 1 nullifier (the first nullifier is used for log indexing) | ||
| const countNullifiers = (max: number, num?: number) => Math.max(1, count(max, num)); |
Contributor
Author
There was a problem hiding this comment.
Needed to update this to make archiver tests pass. It's correct to have min be 1 here because all the tx always have at least 1 nullifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes F-231
Fixes #9789
In this PR I modify the the return value of our "get logs by tags" endpoints such that we don't need to perform another request for tx hash in PXE's log service. Since I was already modifying it I also dropped unused values from the type and made it a bit less messy.
I added here migration notes for all the changes I did to the endpoint not only in this PR but also in PRs down the stack.