refactor: returning last used tagging index #17534
Conversation
| recipient.address, | ||
| ), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
This test will get reworked in a followup PR were I will implement the solution of tracking finalized indexed etc. so would not care too much about this being nice and clear.
benesjan
force-pushed
the
10-07-refactor_returning_last_used_tagging_index
branch
from
485e42f to
55a5541
Compare
| contractAddress: AztecAddress, | ||
| recipient: AztecAddress, | ||
| ): Promise<IndexedTaggingSecret[]> { | ||
| ): Promise<{ secret: DirectionalAppTaggingSecret; index: number | undefined }[]> { |
There was a problem hiding this comment.
This is an ugly change but in a followup PR I will basically delete all the tagging sync and do it again so please tolerate.
| public async syncTaggedLogsAsSender( | ||
| secret: DirectionalAppTaggingSecret, | ||
| contractAddress: AztecAddress, | ||
| ): Promise<void> { |
There was a problem hiding this comment.
Will rewrite this insanity and move it to a different file in a followup PR so wouldn't care about code quality here now.
| */ | ||
| export function getInitialIndexesMap(indexedTaggingSecrets: IndexedTaggingSecret[]): { | ||
| export function getInitialIndexesMap( | ||
| indexedTaggingSecrets: { secret: DirectionalAppTaggingSecret; index: number | undefined }[], |
There was a problem hiding this comment.
Same as before, this became ugly with the change but I will just delete this in a followup PR.
benesjan
force-pushed
the
10-07-refactor_returning_last_used_tagging_index
branch
from
b3b8c16 to
3b0d5e2
Compare
benesjan
force-pushed
the
10-02-feat_executiontaggingindexcache
branch
from
fd39b63 to
cd31177
Compare
AztecBot
force-pushed
the
10-02-feat_executiontaggingindexcache
branch
from
cd31177 to
bad2246
Compare
benesjan
changed the base branch from
10-02-feat_executiontaggingindexcache
to
graphite-base/17534
benesjan
force-pushed
the
10-07-refactor_returning_last_used_tagging_index
branch
from
3b0d5e2 to
9f97dee
Compare
| Object.entries(newLargestIndexMapToStore).map(([directionalAppTaggingSecret, index]) => ({ | ||
| secret: DirectionalAppTaggingSecret.fromString(directionalAppTaggingSecret), | ||
| index, | ||
| index: index - 1, |
There was a problem hiding this comment.
I'm gonna trust you on this one, because this method got kinda insane
Thunkar
left a comment
Thunkar
left a comment
There was a problem hiding this comment.
Eagerly waiting for the next iteration
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
As discussed in a PR down the stack returning the next tagging index in various places of tagging was confusing and it's better to return the last used one. In this PR I do this change.
Some of the code is quite weird but I think it doesn't make sense to invest time in that as I will replace all the tagging sync it all in followup PRs.