refactor: renaming IndexedTaggingSecret as PreTag
#17568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2025
Contributor
Author
benesjan
commented
Oct 8, 2025
| * indexes with tx hash. | ||
| */ | ||
| async #getLastUsedIndexedTaggingSecretsForSenders( | ||
| async #getLastUsedTaggingIndexesForSenders( |
Contributor
Author
There was a problem hiding this comment.
The naming here is confusing as it doesn't return PreTags. Put the TODO above as I expect this all to just go away in followup PRs where the whole tagging sync algo will be rewritten and moved from this file to separate standalone functions in pxe/src/tagging dir.
benesjan
changed the title
IndexedTaggingSecret as PreTag
benesjan
force-pushed
the
10-07-refactor_returning_last_used_tagging_index
branch
from
b3b8c16 to
3b0d5e2
Compare
benesjan
force-pushed
the
10-08-refactor_renaming_indexedtaggingsecret_as_pretag
branch
from
73a8f6d to
778aeaa
Compare
benesjan
force-pushed
the
10-07-refactor_returning_last_used_tagging_index
branch
from
3b0d5e2 to
9f97dee
Compare
benesjan
force-pushed
the
10-08-refactor_renaming_indexedtaggingsecret_as_pretag
branch
from
778aeaa to
0a26d3b
Compare
Thunkar
approved these changes
Oct 14, 2025
Contributor
Thunkar
left a comment
Thunkar
left a comment
There was a problem hiding this comment.
I don't love this name, but I seem to be in the minority. It's also a hard concept to name and I don't think the previous one was much better...so approving
Base automatically changed from
10-07-refactor_returning_last_used_tagging_index
to
next
October 15, 2025 21:16
benesjan
force-pushed
the
10-08-refactor_renaming_indexedtaggingsecret_as_pretag
branch
from
0a26d3b to
16795d9
Compare
benesjan
deleted the
10-08-refactor_renaming_indexedtaggingsecret_as_pretag
branch
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
IndexedTaggingSecretasPreTagas the original name was confusing. See this conversation for more context.