Skip to content

Fix Windows system directory detection for anchored paths #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AperturePlus wants to merge 1 commit into from
Closed

Fix Windows system directory detection for anchored paths #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/aci/core/path_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@ def _is_windows_system_directory(resolved: Path, path_str: str) -> bool:
windows_path = PureWindowsPath(path_str)
win_parts = [part.lower() for part in windows_path.parts if part not in ("\\", "/")]

# Strip drive prefix (e.g., "c:") if present.
if win_parts and re.fullmatch(r"[a-z]:", win_parts[0]):
# Strip Windows anchor prefixes (e.g., "C:\\", "\\\\server\\share\\").
anchor = windows_path.anchor.lower()
if anchor and win_parts and win_parts[0] == anchor:
win_parts = win_parts[1:]
elif win_parts and re.fullmatch(r"[a-z]:", win_parts[0]):
# Defensive fallback for drive-only prefixes represented as "c:".
win_parts = win_parts[1:]

if win_parts and win_parts[0] in WINDOWS_SYSTEM_DIRS:
Expand Down
Loading