Fix Windows system directory detection for anchored paths#6
Closed
AperturePlus wants to merge 1 commit intodevelopfrom
Closed
Fix Windows system directory detection for anchored paths#6AperturePlus wants to merge 1 commit intodevelopfrom
AperturePlus wants to merge 1 commit intodevelopfrom
Conversation
Owner
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_is_windows_system_directoryproduced false negatives for Windows paths that include an anchor (for exampleC:\Program Files (x86)), due to howPureWindowsPath.partsrepresents anchored paths on POSIX hosts.Description
_is_windows_system_directoryinsrc/aci/core/path_utils.pyto inspectPureWindowsPath.anchorand strip Windows anchor prefixes (e.g.C:\,\\server\share\) before examining leading path components againstWINDOWS_SYSTEM_DIRS.c:-style drive prefixes when present.Pathfallback logic intact so native Windows behavior is unchanged.Testing
pytest tests/unit/test_cli.py::TestCLIHelp::test_index_help tests/unit/test_cli.py::TestCLIHelp::test_search_helpand both tests passed locally.ModuleNotFoundError: No module named 'hypothesis'in this environment, so the property-suite validation could not be completed here.4 failed, 665 passed; the change addresses the Windows-path detection failure that caused the property test failures in CI.Codex Task