Release 0.14.0#130
Conversation
Bump rand to 0.9
Relax `Sized` requirements on the rng
|
|
||
| /// Returns an element chosen uniformly at random using a user-provided RNG. | ||
| fn random(rng: impl RngCore) -> Self; | ||
| fn random<R: RngCore + ?Sized>(rng: &mut R) -> Self; |
There was a problem hiding this comment.
This change is blocked on being included in a zkcrypto RFC.
|
CI is failing because changes in |
|
I'm not very familiar with the zkcrypto processes, any chance you could tag and publish a pre-release for 0.14.0? (with #127 preferably). |
|
That's my plan. We do not normally do pre-releases because they are hard to use correctly in general, but given the need to coordinate with RustCrypto I'll be doing so in this instance. And as noted elsewhere, the trait changes in any pre-release builds will not be included in the final release unless they are also in a merged zkcrypto RFC. The pre-release builds we create in this instance should be used for RFC consensus building. |
adds a Field::try_from_rng method
Preview 0.14.0-pre.0
|
RustCrypto have decided to skip This has two main implications:
|
Bump `rand_core` to v0.10; MSRV 1.85
Followup to #149, since the name has been changed in zkcrypto/rfcs#1
Rename `Field::try_from_rng` => `try_random`
ff_derive 0.14: update addchain, num-bigint, syn
| @@ -15,19 +15,20 @@ repository = "https://github.com/zkcrypto/ff" | |||
|
|
|||
| [features] | |||
| # enabled when generating bitvec code utilizing the version of ff's bitvec | |||
There was a problem hiding this comment.
nit; this comment could be clearer, feels circular.
|
If this is going to be a final v0.14.0 release of |
responded to the issue, and filed #156 and zkcrypto/group#81. this seems to require an RFC (like #130 (comment)) which carries a 10-day FCP, so proposing this be included in a next minor point release and not block this release on that change. cc @ebfull @str4d @tarcieri. |
|
Yes, it would require an RFC. And it also requires some more significant design work per #155 (comment). |
|
Crates released and tagged. Thanks! |
This is a feature branch; PR is open to track the overall 0.14.0 changes.