Skip to content

Release 0.14.0#63

Merged
ebfull merged 30 commits into
mainfrom
release-0.14.0
Jun 1, 2026
Merged

Release 0.14.0#63
ebfull merged 30 commits into
mainfrom
release-0.14.0

Conversation

@str4d
Copy link
Copy Markdown
Member

@str4d str4d commented Apr 16, 2025

This is a feature branch; PR is open to track the overall 0.14.0 changes.

tarcieri and others added 11 commits December 30, 2022 10:05
Adds a provided method to the `Group` trait for performing
multiplication by the generator.

The use case is overriding this method in the event that precomputed
scalar multiplication tables are available, which may be conditional
depending on crate features like `alloc` or feature-gated static
precomputed tables.
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
Relax Sized requirements on the rng
Provide a `Group::try_from_rng`
@tcoratger
Copy link
Copy Markdown

Hey @str4d,

Do we have a target date for this to be merged or is it a long term PR that is not intended to be merged right away?

@tarcieri
Copy link
Copy Markdown
Contributor

tarcieri commented Feb 1, 2026

#70 updates rand_core to v0.10 which has been a big blocker

tarcieri and others added 2 commits February 8, 2026 09:07
This unifies the methods previously exposed by the `PrimeCurveAffine`
and `CofactorCurveAffine` traits. The prime-order and cofactor traits
are now all marker traits, and their affine-specific traits are
automatically derived.
@ebfull ebfull marked this pull request as ready for review May 30, 2026 16:06
Copy link
Copy Markdown
Collaborator

@ebfull ebfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK modulo commits I authored.

@tarcieri
Copy link
Copy Markdown
Contributor

It'd be good if some of the items from #80 could be addressed, namely #75 and #78

The release of ff v0.14.0 would suggest the boat has already sailed on zkcrypto/rfcs#3

Copy link
Copy Markdown

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nits.

Comment thread src/lib.rs
Comment thread Cargo.toml
Comment thread src/lib.rs
Comment thread src/lib.rs Outdated
Comment thread src/lib.rs
Comment thread src/cofactor.rs
Comment thread src/lib.rs Outdated
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md
@TalDerei
Copy link
Copy Markdown

TalDerei commented May 30, 2026

It'd be good if some of the items from #80 could be addressed, namely #75 and #78

The release of ff v0.14.0 would suggest the boat has already sailed on zkcrypto/rfcs#3

from that tracking issue, #75 seems like an idiomatic target, will optimistically review #82 (purely additive, backwards compat without ff / trait bound / dep changes). for #78, if the proposed endianness handling lived in group (cc @str4d), it’d require an RFC (new trait + wNAF bounds changes) and don’t think we should block release on that.

@ebfull
Copy link
Copy Markdown
Collaborator

ebfull commented May 30, 2026

Happy to publish 0.14.1 with #82, if it's truly additive. (Haven't had a chance to look.)

@tarcieri
Copy link
Copy Markdown
Contributor

tarcieri commented May 31, 2026

#82 is additive, yes.

It seems fixing #78 is both breaking and needs an RFC, though.

@tarcieri
Copy link
Copy Markdown
Contributor

tarcieri commented May 31, 2026

Also note that while I can take a shot at an RFC I'm still not entirely clear what API would be acceptable.

Should we add a method to e.g. WnafGroup, or should it be a new trait? Does it need an associated type for the bits? What do the bounds on that type look like?

(I think these concerns would be more ergonomic to handle in ff, though there is already a trait for bit-level access based on bitvec, which I would prefer not to use)

@ebfull
Copy link
Copy Markdown
Collaborator

ebfull commented Jun 1, 2026

Published 0.14.0 on crates.io.

@ebfull ebfull merged commit f10610b into main Jun 1, 2026
11 checks passed
@ebfull ebfull deleted the release-0.14.0 branch June 1, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants