Localization improvement #49
Open
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysoftware
added a commit
to ysoftware/SwiftPasscodeLock
that referenced
this pull request
May 17, 2017
moogle19
pushed a commit
to zahlz/SwiftPasscodeLock
that referenced
this pull request
May 22, 2017
* Localization improvements yankodimitrov#49 * Russian localization We're translating our app to more languages, so more to come * Swift 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for localization of Cancel and Delete buttons. Also changed behavior of obtaining localized strings - even if the project has PasscodeLock.strings file, the library will fall back to default string in case of the project doesn't have specified key. This allows to avoid the UI breakage for existing users who have localized their projects, but didn't specify translations for newly introduced keys.