Merge @yankodimitrov main repo PRs #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # PasscodeLock/PasscodeLockViewController.swift
… bundle misses it
Added more detailed information about how to create custom PassLockView.xib, and fixed a typo.
# Conflicts: # PasscodeLock/PasscodeLockPresenter.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have collected all the PRs done at @yankodimitrov main repo so as we have them collected somewhere.
@yankodimitrov I would like to contribute to your repo, but my own fork is not in sync with your master. If you agree let's force push contents of this fork and continue on your repo. Thanks.
NOTE: some of the following PRs haven't fully merged based on what I was thinking is already solved in this fork. Please let me know if I missed anything.
p.s.: @velikanov please check this PR so as we merge it in the master branch
Thanks Chris.