Cross chain announcement#27
Conversation
Add cross-chain announcement schema conformance audit and CKB roundtrip test
|
@clintjeff2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@truthixify Please review and merge |
|
The schema doc is good — clean per-field matrix, severity-tagged findings, and the split between "harmless to align" vs "intentional" divergences makes the canonical SDK form a real outcome rather than just description. Calling out the One note: the SDK-side conformance tests called out in the issue spec live in a separate repo and are already tracked over there as Merging. Thanks @clintjeff2. |
Motivation
Announcementtype for the SDK to consume.Description
ANNOUNCEMENT_SCHEMA.mdat the repo root containing a field-by-field matrix for EVM, Stellar, Solana, and CKB, severity-tagged findings, canonical SDKAnnouncementrecommendation, source-of-truth links, and alignment recommendations.parse_lock_args_roundtripinckb/contracts/wraith-stealth-lock/src/main.rsthat validates theephemeral_pubkey([0..33]) andblake160(stealth_pubkey)([33..53]) slicing assumptions.ckb/Cargo.lock(dependency snapshot changed by running tests/compilation).sdk/src/chains/*/announcements.ts) is not present in this snapshot, so SDK-code linking was not possible from this repo alone.Testing
cd ckb/contracts/wraith-stealth-lock && cargo testand the new testtests::parse_lock_args_roundtrippassed (1 passed).cd stellar/stealth-announcer && cargo testand existing tests passed (2 passed).Closes #12