Skip to content

feat(stellar): add wraith names on-behalf flow#30

Open
sudo-robi wants to merge 1 commit into
wraith-protocol:developfrom
sudo-robi:feat/stellar-wraith-names-on-behalf
Open

feat(stellar): add wraith names on-behalf flow#30
sudo-robi wants to merge 1 commit into
wraith-protocol:developfrom
sudo-robi:feat/stellar-wraith-names-on-behalf

Conversation

@sudo-robi
Copy link
Copy Markdown

closes #10

Copilot AI review requested due to automatic review settings May 28, 2026 08:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 28, 2026

@sudo-robi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@truthixify truthixify changed the base branch from main to develop June 1, 2026 15:06
@truthixify
Copy link
Copy Markdown
Contributor

The on-behalf work is solid — register_on_behalf / update_on_behalf / release_on_behalf are all there, the authorization message helper centralizes the canonical-bytes definition, replay protection is tested (test_register_on_behalf_replay), and the property-based roundtrip is exactly what we need. The proptest snapshot files committed under test_snapshots/ are the right call for CI determinism — keep them.

The blocker is the base — this PR was opened against an older main and is now conflicting hard with develop. The current diff would undo recently-merged work (the proptest harness in #13, the event-topic design doc in #26, the announcement-schema audit in #27, the stuck-funds rescue tool in #28).

Could you rebase onto develop?

git fetch origin
git rebase origin/develop
# don't delete: EVENT_TOPIC_DESIGN.md, ANNOUNCEMENT_SCHEMA.md, POSTMORTEMS.md,
#               scripts/rescue-stealth-funds.ts, scripts/tests/, scripts/README.md,
#               scripts/package.json/.lock, stellar/{announcer,registry,sender}/tests/properties.rs,
#               the stellar-nightly CI job
# your snapshot files under stellar/wraith-names/test_snapshots/ are fine to keep as new files
git push --force-with-lease

Once that's rebased I'll re-review and merge. Really nice work on the auth message + replay nonce design — thanks @sudo-robi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gasless signed .wraith name registration on Stellar

3 participants