Conversation
Generated by 🚫 Danger |
|
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31561 | |
| Version | PR #25400 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e7babf9 | |
| Installation URL | 57v9f9kc85ilg |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31561 | |
| Version | PR #25400 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e7babf9 | |
| Installation URL | 67bnl1638lr8o |
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
| // See https://forums.swift.org/t/swift-cant-see-objc-methods-that-include-package-symbols/65732/9 | ||
| // Without this flag, Objective-C APIs that contains Swift types in WordPressKit will not be available | ||
| // to Swift code in the app target. | ||
| OTHER_SWIFT_FLAGS = $(inherited) -Xcc "-fmodule-map-file=${OBJROOT}/GeneratedModuleMaps-${PLATFORM_NAME}/WordPressKit.modulemap" -Xcc "-fmodule-map-file=${OBJROOT}/GeneratedModuleMaps-${PLATFORM_NAME}/WordPressKitModels.modulemap" -Xcc "-fmodule-map-file=${OBJROOT}/GeneratedModuleMaps-${PLATFORM_NAME}/WordPressKitObjC.modulemap" -Xcc "-fmodule-map-file=${OBJROOT}/GeneratedModuleMaps-${PLATFORM_NAME}/WordPressKitObjCUtils.modulemap" |
There was a problem hiding this comment.
These may no longer be needed. Will look into removing it in separate PRs.
|
What do you think about moving or duplicating |
To add some context, To address the concern - |





This change is a prerequisite for #25392. I need to use
GutenbergExcerptGeneratorfromWordPressSharedinWordPressKitModels. Unfortunately, it results in multiple ObjC-related compiler errors like these:Changes
WordPressShareddependency toWordPressKitModelsandWordPressKitObjCWordPressKitObjCUtilsWordPressKitto use APIs fromWordPressSharedinstead of the ones that were removedWordPressKittarget toPackage.swiftso it would auto-create a scheme