Reader: Add support for <br> tags in excerpt generator#25392
Open
kean wants to merge 6 commits into
Open
Conversation
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31992 | |
| Version | PR #25392 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5775715 | |
| Installation URL | 6didf0dgvpq7g |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31992 | |
| Version | PR #25392 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5775715 | |
| Installation URL | 6kg0midr7ut70 |
Contributor
Author
|
In order to use |
kean
force-pushed
the
fix/summary-with-br-tags
branch
from
b390713 to
c7c2052
Compare
kean
force-pushed
the
fix/summary-with-br-tags
branch
from
218eb41 to
0e16c02
Compare
Contributor
|
FYI, the unit tests job failed. |
Contributor
|
Version |
kean
force-pushed
the
fix/summary-with-br-tags
branch
from
0e16c02 to
736443e
Compare
|
jkmassel
requested changes
Apr 8, 2026
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
Some edge cases:
- What if there is more than one
<br />tag in a row? It should probably collapse into a single space, right? - What if the tags aren't all lowercase (
<BR />is common from HTML processing tools)
| let content = #"<p class="wp-block-paragraph">Yes,<br>look behind<br>in remembrance and with gratitude.</p><p class="wp-block-paragraph">Then,<br>stay present,<br>or miss memories in the making.</p>"# | ||
|
|
||
| let summary = GutenbergExcerptGenerator.firstParagraph(from: content, maxLength: 150) | ||
| print(summary) |
kean
force-pushed
the
fix/summary-with-br-tags
branch
from
736443e to
dc660f3
Compare
kean
force-pushed
the
fix/summary-with-br-tags
branch
from
dc660f3 to
5775715
Compare
Contributor
Author
|
I covered the additional scenarios. Ideally, it should be refactored in the future to use SwiftSoup, but this should cove the vast majority of scenarios. Turned out, the issue was on the backend anyway. Reader always returns an excerpt, even if the post doesn't provide one. |
Contributor
|
Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CMM-82: Reader incorrectly renders newlines in excerpts.
Prerequisite: #25400.
This PR is for excerpts generated on the client. In the case of the post from the issue, the lack of whitespaces is backed in on the server. I opened a separate issue for the Loop team. The client-side one should be considered fixed, which you can see in the unit tests.