Skip to content

Reader: Add support for <br> tags in excerpt generator#25392

Draft
kean wants to merge 3 commits intotrunkfrom
fix/summary-with-br-tags
Draft

Reader: Add support for <br> tags in excerpt generator#25392
kean wants to merge 3 commits intotrunkfrom
fix/summary-with-br-tags

Conversation

@kean
Copy link
Contributor

@kean kean commented Mar 17, 2026

@kean kean added this to the 26.8 milestone Mar 17, 2026
@kean kean added the Reader label Mar 17, 2026
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 17, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number31559
VersionPR #25392
Bundle IDorg.wordpress.alpha
Commitb390713
Installation URL1stfa7097bji8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 17, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number31559
VersionPR #25392
Bundle IDcom.jetpack.alpha
Commitb390713
Installation URL2s4b32f1t5avg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 17, 2026

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@kean
Copy link
Contributor Author

kean commented Mar 18, 2026

In order to use WordPressShared in WordPressKitModel, it looks like I first need to resolve some issues with ObjC headers and helper methods duplicated in WPKit:

Found the issue. Both WordPressSharedObjC and WordPressKitObjC have a public header named WPMapFilterReduce.h. Now that WordPressKitObjC transitively depends on WordPressSharedObjC (via WordPressKitModels → WordPressShared → WordPressSharedObjC), the compiler resolves #import "WPMapFilterReduce.h" to WordPressSharedObjC's version — which defines WPMapBlock/WPFilterBlock but not WPKitMapBlock/WPKitFilterBlock.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants