Draft
Conversation
Collaborator
Generated by 🚫 Danger |
|
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Remaining Issues
Class Mapping
Crash when using the non-objc classes that represent entities:
Before moving these types to SwiftPM, the class names were:
After the move:
Explanation:
When a Core Data entity's managedObjectClassName is set to something like BlogSettings, Core Data looks it up in the ObjC runtime. In an Xcode framework
target, Swift classes are automatically registered as ModuleName.ClassName (e.g., WordPressData.BlogSettings). But SwiftPM targets don't auto-register
Swift classes with the ObjC runtime the same way — unless the class has an explicit @objc annotation.
When Core Data can't find the class, it dynamically generates a generic NSManagedObject subclass (hence NSManagedObject_BlogSettings_3), and the cast
fails.
The fix: Add @objc(ClassName) to each affected managed object subclass. This explicitly registers the class with the ObjC runtime under a stable name
that Core Data can find.