Skip to content

Use global class names for Core Data entities#25378

Merged
kean merged 1 commit intotrunkfrom
task/objc-based-represented-class-name
Mar 19, 2026
Merged

Use global class names for Core Data entities#25378
kean merged 1 commit intotrunkfrom
task/objc-based-represented-class-name

Conversation

@kean
Copy link
Contributor

@kean kean commented Mar 13, 2026

This is a prerequisite for #25377. For most classes that represent Core Entities, we simply use @objc class names to put them into the global namespace, which is a recommended practice. This PR updates the remaining classes, so they all follow the same practice.

Potential issues: collisions at runtime; unlikely since most of the code is now in Swift.
Note on migration: WordPress 158 is shipping in 26.8, so I added the change to it.

@dangermattic
Copy link
Collaborator

dangermattic commented Mar 13, 2026

1 Warning
⚠️ This PR is assigned to the milestone 26.8. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 13, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number31562
VersionPR #25378
Bundle IDorg.wordpress.alpha
Commit5f5e9e0
Installation URL1nqglkek26o90
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 13, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number31562
VersionPR #25378
Bundle IDcom.jetpack.alpha
Commit5f5e9e0
Installation URL4dmji4idha0uo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean added this to the 26.8 milestone Mar 18, 2026
@kean kean force-pushed the task/objc-based-represented-class-name branch from 14cc543 to 5f5e9e0 Compare March 18, 2026 16:12
@kean kean marked this pull request as ready for review March 18, 2026 16:12
@sonarqubecloud
Copy link

@kean kean added this pull request to the merge queue Mar 19, 2026
Merged via the queue into trunk with commit 6ab5023 Mar 19, 2026
27 checks passed
@kean kean deleted the task/objc-based-represented-class-name branch March 19, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants