Use NoInternalImports to enforce module boundaries

cli/elm.json

@@ -2,8 +2,7 @@
     "type": "application",
     "source-directories": [
         "src",
-        "../src",
-        "../codegen"
+        "../src"
     ],
     "elm-version": "0.19.1",
     "dependencies": {
@@ -22,7 +21,6 @@
             "mdgriffith/elm-codegen": "5.2.0",
             "miniBill/elm-fast-dict": "1.2.4",
             "robinheghan/murmur3": "1.0.0",
-            "turboMaCk/non-empty-list-alias": "1.4.0",
             "wolfadex/elm-ansi": "3.0.0",
             "wolfadex/elm-open-api": "2.0.0"
         },
@@ -69,4 +67,4 @@
         "direct": {},
         "indirect": {}
     }
-}
+}

cli/review/elm.json

@@ -0,0 +1,43 @@
+{
+    "type": "application",
+    "source-directories": [
+        "src"
+    ],
+    "elm-version": "0.19.1",
+    "dependencies": {
+        "direct": {
+            "elm/core": "1.0.5",
+            "elm/json": "1.1.4",
+            "elm/project-metadata-utils": "1.0.2",
+            "elmcraft/core-extra": "2.2.0",
+            "jfmengels/elm-review": "2.15.5",
+            "jfmengels/elm-review-code-style": "1.2.0",
+            "jfmengels/elm-review-common": "1.3.4",
+            "jfmengels/elm-review-debug": "1.0.8",
+            "jfmengels/elm-review-documentation": "2.0.4",
+            "jfmengels/elm-review-simplify": "2.1.10",
+            "jfmengels/elm-review-unused": "1.2.4",
+            "miniBill/elm-review-no-internal-imports": "1.0.0",
+            "stil4m/elm-syntax": "7.3.9"
+        },
+        "indirect": {
+            "elm/bytes": "1.0.8",
+            "elm/html": "1.0.1",
+            "elm/parser": "1.1.0",
+            "elm/random": "1.0.0",
+            "elm/regex": "1.0.0",
+            "elm/time": "1.0.0",
+            "elm/virtual-dom": "1.0.5",
+            "elm-explorations/test": "2.2.0",
+            "pzp1997/assoc-list": "1.0.0",
+            "rtfeldman/elm-hex": "1.0.0",
+            "stil4m/structured-writer": "1.0.3"
+        }
+    },
+    "test-dependencies": {
+        "direct": {
+            "elm-explorations/test": "2.2.0"
+        },
+        "indirect": {}
+    }
+}

cli/review/src/ReviewConfig.elm

@@ -0,0 +1,63 @@
+module ReviewConfig exposing (config)
+
+{-| Do not rename the ReviewConfig module or the config function, because
+`elm-review` will look for these.
+
+To add packages that contain rules, add them to this review project using
+
+    `elm install author/packagename`
+
+when inside the directory containing this file.
+
+-}
+
+import Docs.ReviewAtDocs
+import NoConfusingPrefixOperator
+import NoDebug.Log
+import NoDebug.TodoOrToString
+import NoExposingEverything
+import NoImportingEverything
+import NoInternalImports
+import NoMissingTypeAnnotation
+import NoMissingTypeAnnotationInLetIn
+import NoMissingTypeExpose
+import NoPrematureLetComputation
+import NoSimpleLetBody
+import NoUnused.CustomTypeConstructorArgs
+import NoUnused.CustomTypeConstructors
+import NoUnused.Dependencies
+import NoUnused.Exports
+import NoUnused.Parameters
+import NoUnused.Patterns
+import NoUnused.Variables
+import Review.Rule as Rule exposing (Rule)
+import Simplify
+
+
+config : List Rule
+config =
+    [ Docs.ReviewAtDocs.rule
+    , NoConfusingPrefixOperator.rule
+    , NoDebug.Log.rule
+    , NoDebug.TodoOrToString.rule
+        |> Rule.ignoreErrorsForDirectories [ "tests/" ]
+    , NoExposingEverything.rule
+    , NoImportingEverything.rule []
+    , NoMissingTypeAnnotation.rule
+    , NoMissingTypeAnnotationInLetIn.rule
+    , NoMissingTypeExpose.rule
+    , NoSimpleLetBody.rule
+    , NoPrematureLetComputation.rule
+    , NoUnused.CustomTypeConstructors.rule []
+    , NoUnused.CustomTypeConstructorArgs.rule
+    , NoUnused.Dependencies.rule
+    , NoUnused.Exports.rule
+        |> Rule.ignoreErrorsForDirectories [ "../src" ]
+        |> Rule.ignoreErrorsForFiles [ "src/Cli.elm" ]
+    , NoUnused.Parameters.rule
+    , NoUnused.Patterns.rule
+    , NoUnused.Variables.rule
+    , Simplify.rule Simplify.defaults
+    , NoInternalImports.rule [ "../src" ]
+    ]
+        |> List.map (Rule.ignoreErrorsForDirectories [ "../src/Gen" ])

cli/review/suppressed/NoInternalImports.json

@@ -0,0 +1,8 @@
+{
+  "version": 1,
+  "automatically created by": "elm-review suppress",
+  "learn more": "elm-review suppress --help",
+  "suppressions": [
+    { "count": 2, "filePath": "src/Cli.elm" }
+  ]
+}

cli/review/suppressed/NoUnused.Dependencies.json

@@ -0,0 +1,8 @@
+{
+  "version": 1,
+  "automatically created by": "elm-review suppress",
+  "learn more": "elm-review suppress --help",
+  "suppressions": [
+    { "count": 1, "filePath": "elm.json" }
+  ]
+}

cli/review/suppressed/NoUnused.Exports.json

@@ -0,0 +1,8 @@
+{
+  "version": 1,
+  "automatically created by": "elm-review suppress",
+  "learn more": "elm-review suppress --help",
+  "suppressions": [
+    { "count": 1, "filePath": "src/TestGenScript.elm" }
+  ]
+}