Use NoInternalImports to enforce module boundaries #237
+132
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamdicarlo0
reviewed
Jan 9, 2026
Contributor
adamdicarlo0
left a comment
adamdicarlo0
left a comment
There was a problem hiding this comment.
Nice! Could you also set this up for CI? In other words,
- run this in the
reviewnpm script - add the new
elm.jsonfile to the.github/workflows/ci.yamlhashFiles declarations (or I will do this in a separate PR - it's actually already missing twoelm.jsonfiles)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs integration into CI but makes the "separate into CLI and package" objective more measurable: we will have succeeded when we can remove the suppressions for the new rule