Skip to content

fix(cache): add Package-scoped negative globs to prevent cache miss in monorepos#1198

Merged
graphite-app[bot] merged 1 commit intomainfrom
fix-cache-missing
Mar 30, 2026
Merged

fix(cache): add Package-scoped negative globs to prevent cache miss in monorepos#1198
graphite-app[bot] merged 1 commit intomainfrom
fix-cache-missing

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 29, 2026

In monorepos, each package has its own node_modules/. When vp build/test/pack
run, Vite creates .vite-temp/ config files and dist/ outputs that are both read
and written during execution. The existing !node_modules/.vite-temp/** glob at
Workspace scope only matched the workspace root, not package-level paths,
causing perpetual cache misses due to read-write overlap detection.

  • Build: add Package-scoped !node_modules/.vite-temp/** and !dist/**
  • Test: add Package-scoped !node_modules/.vite-temp/** and !node_modules/.vite/**/results.json
  • Pack: add Package-scoped !node_modules/.vite-temp/** and !dist/**

Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 29, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from a72e61b to bc5fcd7 Compare March 29, 2026 11:45
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from bc5fcd7 to 485d4ea Compare March 29, 2026 14:52
@graphite-app graphite-app bot force-pushed the fix-cache-missing branch from 485d4ea to 9e18cef Compare March 29, 2026 15:45
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from 9e18cef to a10da80 Compare March 30, 2026 02:39
@fengmk2 fengmk2 marked this pull request as ready for review March 30, 2026 02:43
@fengmk2 fengmk2 requested a review from branchseer March 30, 2026 02:43
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from a10da80 to 92296d9 Compare March 30, 2026 06:33
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from 92296d9 to 1804447 Compare March 30, 2026 06:49
@fengmk2 fengmk2 force-pushed the fix-issue-1176 branch 2 times, most recently from 538ff45 to ffbfc0c Compare March 30, 2026 07:24
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from 1804447 to 2b050e5 Compare March 30, 2026 07:24
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from 2b050e5 to 04abde5 Compare March 30, 2026 07:40
@graphite-app graphite-app bot force-pushed the fix-cache-missing branch from 04abde5 to f8066fd Compare March 30, 2026 08:38
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch 2 times, most recently from ea53d50 to 854d4c2 Compare March 30, 2026 09:50
@graphite-app graphite-app bot changed the base branch from fix-issue-1176 to graphite-base/1198 March 30, 2026 13:15
@fengmk2 fengmk2 force-pushed the graphite-base/1198 branch from e60358a to cf7593e Compare March 30, 2026 13:16
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from 854d4c2 to 71a35e0 Compare March 30, 2026 13:16
@fengmk2 fengmk2 changed the base branch from graphite-base/1198 to fix-issue-1176 March 30, 2026 13:17
@graphite-app graphite-app bot changed the base branch from fix-issue-1176 to main March 30, 2026 13:28
@fengmk2 fengmk2 force-pushed the fix-cache-missing branch from 71a35e0 to 6cd75f4 Compare March 30, 2026 14:32
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 3fc8005
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69ca90ca83babc00080de9b6

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 30, 2026

Merge activity

…n monorepos (#1198)

In monorepos, each package has its own node_modules/. When vp build/test/pack
run, Vite creates .vite-temp/ config files and dist/ outputs that are both read
and written during execution. The existing !node_modules/.vite-temp/** glob at
Workspace scope only matched the workspace root, not package-level paths,
causing perpetual cache misses due to read-write overlap detection.

- Build: add Package-scoped !node_modules/.vite-temp/** and !dist/**
- Test: add Package-scoped !node_modules/.vite-temp/** and !node_modules/.vite/**/results.json
- Pack: add Package-scoped !node_modules/.vite-temp/** and !dist/**
@graphite-app graphite-app bot force-pushed the fix-cache-missing branch from 6cd75f4 to 3fc8005 Compare March 30, 2026 15:03
@graphite-app graphite-app bot merged commit 3fc8005 into main Mar 30, 2026
33 checks passed
@graphite-app graphite-app bot deleted the fix-cache-missing branch March 30, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants