Skip to content

refactor: remove PM fallback from vp run, always delegate to vite-plus#1179

Merged
graphite-app[bot] merged 1 commit intomainfrom
vp-run-no-fallback
Mar 30, 2026
Merged

refactor: remove PM fallback from vp run, always delegate to vite-plus#1179
graphite-app[bot] merged 1 commit intomainfrom
vp-run-no-fallback

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 28, 2026

The run_or_delegate module previously fell back to <pm> run <script>
when vite-plus was not a project dependency. This is no longer needed
because the global CLI ships with its own vite-plus installation, and
delegate::execute() already resolves local vite-plus first then falls
back to the global one.

Now vp run and vpr always delegate through the vite-plus task runner,
regardless of whether the project has vite-plus as a dependency.

Closes #1132

@fengmk2 fengmk2 self-assigned this Mar 28, 2026
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 28, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the vp-run-no-fallback branch 2 times, most recently from f0fe3df to 3af4839 Compare March 28, 2026 08:40
@fengmk2 fengmk2 force-pushed the vp-run-no-fallback branch from 3af4839 to 3048c0d Compare March 29, 2026 11:36
@fengmk2 fengmk2 force-pushed the vp-run-no-fallback branch from 3048c0d to ad0a0c7 Compare March 29, 2026 14:52
@graphite-app graphite-app bot force-pushed the vp-run-alias-vpr branch 2 times, most recently from 959f493 to cf48911 Compare March 29, 2026 15:43
@graphite-app graphite-app bot force-pushed the vp-run-no-fallback branch from ad0a0c7 to 6c24f5a Compare March 29, 2026 15:44
@fengmk2 fengmk2 force-pushed the vp-run-no-fallback branch from 6c24f5a to 707c56a Compare March 30, 2026 02:39
@fengmk2 fengmk2 marked this pull request as ready for review March 30, 2026 02:43
@fengmk2 fengmk2 requested review from branchseer and cpojer March 30, 2026 02:43
@fengmk2 fengmk2 force-pushed the vp-run-no-fallback branch 2 times, most recently from 9a5c382 to e4862b2 Compare March 30, 2026 06:49
@fengmk2 fengmk2 force-pushed the vp-run-no-fallback branch from e4862b2 to f898075 Compare March 30, 2026 07:25
@fengmk2 fengmk2 force-pushed the vp-run-no-fallback branch from f898075 to 0e5b9c2 Compare March 30, 2026 07:40
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 30, 2026

Merge activity

…lus (#1179)

The `run_or_delegate` module previously fell back to `<pm> run <script>`
when vite-plus was not a project dependency. This is no longer needed
because the global CLI ships with its own vite-plus installation, and
`delegate::execute()` already resolves local vite-plus first then falls
back to the global one.

Now `vp run` and `vpr` always delegate through the vite-plus task runner,
regardless of whether the project has vite-plus as a dependency.

Closes #1132
@graphite-app graphite-app bot force-pushed the vp-run-alias-vpr branch from 834d8e5 to acee8b6 Compare March 30, 2026 08:20
@graphite-app graphite-app bot force-pushed the vp-run-no-fallback branch from 0e5b9c2 to c682cb1 Compare March 30, 2026 08:21
Base automatically changed from vp-run-alias-vpr to main March 30, 2026 08:31
@graphite-app graphite-app bot merged commit c682cb1 into main Mar 30, 2026
29 checks passed
@graphite-app graphite-app bot deleted the vp-run-no-fallback branch March 30, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp run is not interactive if called without additional parameters

2 participants