-
Notifications
You must be signed in to change notification settings - Fork 11
refactor: restructure into 3-crate workspace per ADR-03 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
745cb0a
d1d65bf
0fe9dd9
413a541
bec31f3
e90b275
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,16 @@ | ||
| [package] | ||
| name = "agentic-api" | ||
| [workspace] | ||
| members = ["crates/*"] | ||
| resolver = "3" | ||
|
|
||
| [workspace.package] | ||
| version = "0.1.0" | ||
| edition = "2024" | ||
| description = "Stateful API logic for agentic applications using vLLM" | ||
| license = "Apache-2.0" | ||
| repository = "https://github.com/vllm-project/agentic-api" | ||
|
|
||
| [dependencies] | ||
| axum = "0.8" | ||
| bytes = "1" | ||
| clap = { version = "4", features = ["derive", "env"] } | ||
| futures = "0.3" | ||
| http = "1" | ||
| reqwest = { version = "0.12", features = ["stream"] } | ||
| serde = { version = "1", features = ["derive"] } | ||
| serde_json = "1" | ||
| thiserror = "2" | ||
| tokio = { version = "1", features = ["full"] } | ||
| tower-http = { version = "0.6", features = ["cors"] } | ||
| tracing = "0.1" | ||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } | ||
|
|
||
| [dev-dependencies] | ||
| criterion = { version = "0.5", features = ["async_tokio"] } | ||
| reqwest = { version = "0.12", features = ["json"] } | ||
|
|
||
| [[bench]] | ||
| name = "proxy_bench" | ||
| harness = false | ||
|
|
||
| [lints.rust] | ||
| [workspace.lints.rust] | ||
| unsafe_code = "forbid" | ||
|
|
||
| [lints.clippy] | ||
| [workspace.lints.clippy] | ||
| all = { level = "deny", priority = -1 } | ||
| pedantic = { level = "warn", priority = -1 } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| [package] | ||
| name = "agentic-core" | ||
| description = "Framework-agnostic core library for agentic-api" | ||
| version.workspace = true | ||
| edition.workspace = true | ||
| license.workspace = true | ||
| repository.workspace = true | ||
|
|
||
| [dependencies] | ||
| bytes = "1" | ||
| futures = "0.3" | ||
| http = "1" | ||
| reqwest = { version = "0.12", features = ["stream"] } | ||
| serde = { version = "1", features = ["derive"] } | ||
| serde_json = "1" | ||
| thiserror = "2" | ||
| tokio = { version = "1", features = ["time"] } | ||
| tracing = "0.1" | ||
|
|
||
| [lints] | ||
| workspace = true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,11 +5,11 @@ pub enum Error { | |
| #[error("failed to build HTTP client")] | ||
| HttpClient(#[source] reqwest::Error), | ||
|
|
||
| #[error("vLLM not ready within {timeout_s:.0}s at {url}")] | ||
| VllmTimeout { url: String, timeout_s: f64 }, | ||
| #[error("LLM not ready within {timeout_s:.0}s at {url}")] | ||
| LlmTimeout { url: String, timeout_s: f64 }, | ||
|
|
||
| #[error("vLLM subprocess exited before becoming ready: {status}")] | ||
| VllmProcessExited { status: String }, | ||
| #[error("LLM subprocess exited before becoming ready: {status}")] | ||
| LlmProcessExited { status: String }, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's separate out the error that is related to |
||
|
|
||
| #[error(transparent)] | ||
| Io(#[from] io::Error), | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| pub mod app; | ||
| pub mod config; | ||
| pub mod error; | ||
| pub mod proxy; | ||
| pub mod server; | ||
| pub mod readiness; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to
errors.rslet's only keep in config thatagentic-corewould need.I think as off now
agentic-corewouldnt need anyconfigtill we setup database and the rest of the features in core.