refactor: restructure into 3-crate workspace per ADR-03#29
Open
leseb wants to merge 6 commits into
Open
Conversation
Collaborator
Author
5 tasks
ashwing
reviewed
May 26, 2026
ashwing
reviewed
May 26, 2026
ashwing
reviewed
May 26, 2026
Restructure the flat crate into a Cargo workspace with three crates: - agentic-core: framework-agnostic library (proxy logic, config, error, readiness). No axum/clap/tower dependencies. - agentic-server: axum binary with CLI, thin handler adapter, server lifecycle, and vLLM subprocess management. - agentic-praxis: stub for future Praxis gateway adapter. Rename vllm_* identifiers to llm_* throughout for gateway-agnostic naming. All existing tests and benchmarks migrate to agentic-server with updated imports. Signed-off-by: Sébastien Han <seb@redhat.com>
- Add tracing::warn for LLM timeout, connection, and body-read errors - Use append instead of insert for multi-value header forwarding - Set content-type on error responses - Add 900s timeout on stream client to prevent infinite hangs - Use PAYLOAD_TOO_LARGE (413) instead of BAD_REQUEST for body size - Deduplicate CLI args into shared CommonArgs struct - Move bytes/futures/reqwest to dev-dependencies in agentic-server Signed-off-by: Sébastien Han <seb@redhat.com>
Update the placeholder comment to reflect ADR-03's direction: multiple HttpFilter implementations (one per core function) composed into a Praxis filter chain with branch support for tool-call looping. Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
requested review from
bbrowning,
franciscojavierarceo,
jiahuei,
maralbahari,
noobHappylife,
qandrew and
tjtanaa
as code owners
Signed-off-by: Sébastien Han <seb@redhat.com>
Collaborator
Author
|
@ashwing thanks for the review, i'd be happy to discuss some of your followup items in issues, thanks! |
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures the flat single-crate layout into a Cargo workspace with three crates per ADR-03:
proxy_request()as a composable building block.clap), server lifecycle, vLLM subprocess management.Built on top of PR #24's proxy gateway code (cherry-picked with full commit history). Renames
vllm_*identifiers tollm_*for gateway-agnostic naming. Includes improvements to error logging, multi-value header forwarding, and CLI arg deduplication.Test Plan
cargo test --workspace— 16 tests pass (7 unit in agentic-core + 9 integration in agentic-server)cargo clippy --workspace --all-targets -- -D warnings— cleancargo fmt -- --check— cleancargo bench -p agentic-server --no-run— benchmarks compile