RSDK-13105: Changes to GetKinematicsResponse to support URDFs containing meshes being sent over the wire #803
+201
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfranczak
added
the
ready-for-protos
nfranczak
changed the title
npmenard
approved these changes
Jan 12, 2026
Member
npmenard
left a comment
npmenard
left a comment
There was a problem hiding this comment.
LGTM, it's been a while that I have made API changes so don't hesitate to ask someone else for a sanity check
npmenard
reviewed
Jan 12, 2026
| // The byte contents of the file | ||
| bytes kinematics_data = 2; | ||
| // Map of URDF mesh file paths to mesh data | ||
| map<string, Mesh> meshes_by_urdf_filepath = 3; |
Member
There was a problem hiding this comment.
double check if this field needs to be optional
Member
Author
There was a problem hiding this comment.
does not need to be optional.
nfranczak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.