Skip to content

[APP-14658] Default Fragments Field #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tgritter merged 2 commits into from
Jan 13, 2026
Merged

[APP-14658] Default Fragments Field #802

tgritter merged 2 commits into from
Jan 13, 2026

Conversation

@tgritter
Copy link
Member

@tgritter tgritter commented Jan 7, 2026 •
edited
Loading

This PR renames the fragment_imports field to default_fragments

Links

@github-actions github-actions bot added the safe to test committer is a member of this org label Jan 7, 2026
@tgritter tgritter added the ready-for-protos add this when you want protos to compile on every commit label Jan 7, 2026
@tgritter tgritter added the allow breaking Allow breaking changes by bypassing the buf-breaking check label Jan 7, 2026
@tgritter tgritter marked this pull request as ready for review January 7, 2026 14:57
@tgritter
Copy link
Member Author

tgritter commented Jan 7, 2026

Correct me if I'm wrong, but we want to add the allow breaking label here? Since it's not being used in production, it won't actually break anything contrary to what the linter thinks.

@tgritter tgritter requested a review from gmulz January 7, 2026 14:58
@tgritter tgritter force-pushed the APP-14658/default-fragments branch from b50f354 to d61f38c Compare January 9, 2026 17:54
@tgritter tgritter force-pushed the APP-14658/default-fragments branch from 4c0a89c to 1e0978c Compare January 13, 2026 21:14
@tgritter tgritter added ready-for-protos add this when you want protos to compile on every commit protos-compiled and removed protos-compiled ready-for-protos add this when you want protos to compile on every commit labels Jan 13, 2026
@tgritter tgritter merged commit e372333 into main Jan 13, 2026
12 of 19 checks passed
@tgritter tgritter deleted the APP-14658/default-fragments branch January 13, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmulz gmulz gmulz approved these changes

Assignees

No one assigned

Labels

allow breaking Allow breaking changes by bypassing the buf-breaking check ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tgritter @gmulz