Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jan 20, 2026

using cargo-shear I found unused dependencies

Fix #10375

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

wahou
i am curious, how did you detect this ?

@oech3
Copy link
Contributor

oech3 commented Jan 21, 2026

i am curious, how did you detect this ?

#10375 (comment)

@sylvestre
Copy link
Contributor

thanks :)

@sylvestre
Copy link
Contributor

ERROR taplo:format_files: the file is not properly formatted path="/home/runner/work/coreutils/coreutils/Cargo.toml"

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 3.85%

Comparing xtqqczze:cargo-shear (bcefded) with main (cbbff30)

Summary

⚡ 1 improved benchmark
✅ 141 untouched benchmarks
⏩ 180 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_ascii_utf8_locale 18.1 ms 17.5 ms +3.85%

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze xtqqczze marked this pull request as ready for review January 21, 2026 17:06
@xtqqczze
Copy link
Contributor Author

We should also consider CI check, opened #10415

@sylvestre sylvestre merged commit 786a33d into uutils:main Jan 21, 2026
132 checks passed
@xtqqczze xtqqczze deleted the cargo-shear branch January 21, 2026 18:52
mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove unused dependencies

3 participants