Skip to content

Conversation

@nyurik
Copy link
Contributor

@nyurik nyurik commented Jun 3, 2025

Try to remove all unused dependencies from various crates

@nyurik nyurik marked this pull request as draft June 3, 2025 19:47
@nyurik nyurik force-pushed the udeps branch 4 times, most recently from d59d331 to db851d4 Compare June 3, 2025 20:19
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@nyurik nyurik force-pushed the udeps branch 2 times, most recently from 2bcbd4b to d5dfcfe Compare June 3, 2025 22:20
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

i am confused. Seems some duplicate on #8058 ?

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

@sylvestre no, this WIP contains 8058, but it also removes a lot of unneeded dependencies - but lets only merge this after 8058 lands

@cakebaker
Copy link
Contributor

Fyi, you are adding some very old stuff, like clap 2.x.

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

@cakebaker not sure where you saw this

@cakebaker
Copy link
Contributor

@nyurik in Cargo.lock

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

ah, yes - well, that dependency is a dev dependency by a crate which was not part of the workspace -- all these changes are in #8058. Having it in a workspace would raise awareness of that crate, and will allow us to update all of its dependencies - rather than uu_factor_benches accidentally being forgotten and not reviewed.

❯ cargo tree --workspace -i clap@2
clap v2.34.0
└── criterion v0.3.6
    [dev-dependencies]
    └── uu_factor_benches v0.0.0 (/home/nyurik/dev/rust/coreutils/tests/benches/factor)

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

needs rebasing now :)

@github-actions
Copy link

github-actions bot commented Jun 6, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@nyurik nyurik force-pushed the udeps branch 4 times, most recently from b70a1e9 to 79475bc Compare July 2, 2025 23:44
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@nyurik nyurik marked this pull request as ready for review July 3, 2025 00:42
@nyurik
Copy link
Contributor Author

nyurik commented Jul 3, 2025

ok, this seemed to have finally passed all tests

@cakebaker cakebaker merged commit faa2dfa into uutils:main Jul 3, 2025
76 checks passed
@cakebaker
Copy link
Contributor

Nice, thanks!

@nyurik nyurik deleted the udeps branch July 3, 2025 16:22
@xtqqczze
Copy link
Contributor

@nyurik FYI I used cargo-shear in #10404 to find and remove unused Rust dependencies (cargo shear --fix).

@nyurik
Copy link
Contributor Author

nyurik commented Jan 22, 2026

thanks! I usually use cargo-udeps -- both have recently been updated, and udeps has had many more downloads, but it seems shear has a bit more functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants