Skip to content

Fix Warnings #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CanerKaraca23 wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −19
Open

Fix Warnings #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
976f5c7
Update build.yml
CanerKaraca23 Apr 11, 2026
bcd3736
Update xmake.lua
CanerKaraca23 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Based on CanerKaraca20 build script
# Based on CanerKaraca23 build script
name: Build ModelExtras

on:
Expand All @@ -25,19 +25,17 @@ jobs:
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y wget gnupg software-properties-common lsb-release g++-mingw-w64-i686
sudo apt-get install -y gnupg software-properties-common lsb-release g++-mingw-w64-i686

# Download LLVM installer script
wget https://apt.llvm.org/llvm.sh
curl -fsSL https://apt.llvm.org/llvm.sh -o llvm.sh
chmod +x llvm.sh

# Install Clang 23
sudo ./llvm.sh 23

- name: Verify Clang
run: |
clang --version
clang++ --version
# Prefer LLVM 23 binaries (clang/clang++)
echo "/usr/lib/llvm-23/bin" >> "$GITHUB_PATH"

- name: Get latest plugin-sdk commit
id: plugin-sdk-ref
Expand All @@ -63,7 +61,7 @@ jobs:
done

FLAGS="-I. -Ishared -Ishared/game -Iplugin_sa -Iplugin_sa/game_sa -Iplugin_sa/game_sa/rw -Isafetyhook -DGTASA -DPLUGIN_SGV_10US -DRW"
CLANG_FLAGS="--target=i686-w64-mingw32 -fpermissive -fcommon -fms-extensions -Wno-microsoft-include -Wno-invalid-offsetof -Wno-builtin-macro-redefined -O2 -D__cpp_concepts=202202L"
CLANG_FLAGS="--target=i686-w64-mingw32 -fpermissive -fcommon -fms-extensions -Wno-microsoft-include -Wno-builtin-macro-redefined -Wno-macro-redefined -Wno-comment -Wno-new-returns-null -Wno-deprecated-enum-enum-conversion -Wno-pragma-once-outside-header -Wno-invalid-offsetof -O2 -D__cpp_concepts=202202L"

find shared plugin_sa safetyhook -name '*.cpp' -print0 | \
xargs -0 -P$(nproc) -I{} clang++-23 $CLANG_FLAGS -std=c++2b $FLAGS -c {} -o obj/{}.o
Expand All @@ -85,7 +83,6 @@ jobs:
--mingw=/usr \
--cc=clang-23 \
--cxx=clang++-23 \
--cxflags="-D__cpp_concepts=202002L" \
-c -y
xmake -j$(nproc)

Expand Down
26 changes: 16 additions & 10 deletions xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,23 @@ target("ModelExtras")
)

add_cxflags(
"--target=i686-w64-mingw32",
"-fpermissive",
"-fcommon",
"-fms-extensions",
"--target=i686-w64-mingw32",
"-fpermissive",
"-fcommon",
"-fms-extensions",
"-fno-finite-math-only",
"-Wno-invalid-offsetof",
"-Wno-microsoft-include",
"-g",
"-gdwarf-2",
"-fdebug-macro"
"-Wno-return-type-c-linkage",
"-D__cpp_concepts=202002L",
"-Wno-builtin-macro-redefined",
"-Wno-deprecated-enum-enum-conversion",
"-Wno-pointer-bool-conversion",
"-Wno-missing-declarations",
"-g",
"-gdwarf-2",
"-fdebug-macro"
)

add_shflags(
"-static",
"-static-libgcc",
Expand Down Expand Up @@ -101,6 +107,6 @@ target("ModelExtras")
set_symbols('debug')
else
add_links("plugin")
set_optimize("aggressive")
set_optimize("fastest")
set_symbols('hidden')
end
Loading