Skip to content

Fix Warnings#228

Open
CanerKaraca23 wants to merge 2 commits intouser-grinch:mainfrom
CanerKaraca23:warnings
Open

Fix Warnings#228
CanerKaraca23 wants to merge 2 commits intouser-grinch:mainfrom
CanerKaraca23:warnings

Conversation

@CanerKaraca23
Copy link
Copy Markdown
Contributor

  • Fix all warnings for clean build.
  • Fix CI not using Clang 23.

Copilot AI review requested due to automatic review settings April 11, 2026 11:34
@CanerKaraca23
Copy link
Copy Markdown
Contributor Author

After merge, i will try to fix by code instead of suppressing warnings with flags.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s build configuration to reduce compiler warnings and adjusts CI so Clang 23 is installed and preferred during the Linux build.

Changes:

  • Expanded Clang compile flags in xmake.lua (including additional warning suppressions) and adjusted release optimization level.
  • Updated the GitHub Actions workflow to install Clang 23 via LLVM’s installer script and prefer LLVM 23 binaries on PATH.
  • Tweaked CI compile flags used when building the cached plugin-sdk artifact and removed an extra --cxflags override from the xmake invocation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
xmake.lua Adds/adjusts Clang flags for warning cleanup and changes release optimization to fastest.
.github/workflows/build.yml Installs and prefers Clang 23 in CI; updates download method and CI clang flag set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants