Open
Conversation
Contributor
CanerKaraca23
commented
Apr 11, 2026
- Fix all warnings for clean build.
- Fix CI not using Clang 23.
Contributor
Author
|
After merge, i will try to fix by code instead of suppressing warnings with flags. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s build configuration to reduce compiler warnings and adjusts CI so Clang 23 is installed and preferred during the Linux build.
Changes:
- Expanded Clang compile flags in
xmake.lua(including additional warning suppressions) and adjusted release optimization level. - Updated the GitHub Actions workflow to install Clang 23 via LLVM’s installer script and prefer LLVM 23 binaries on
PATH. - Tweaked CI compile flags used when building the cached
plugin-sdkartifact and removed an extra--cxflagsoverride from the xmake invocation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
xmake.lua |
Adds/adjusts Clang flags for warning cleanup and changes release optimization to fastest. |
.github/workflows/build.yml |
Installs and prefers Clang 23 in CI; updates download method and CI clang flag set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.