Skip to content

fix: validate Linux spec early to prevent nil dereference panics #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishi-jat wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

fix: validate Linux spec early to prevent nil dereference panics #650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5b1aaf
fix: validate Linux spec early to prevent nil dereference panics
rishi-jat May 10, 2026
3eff01d
fix
rishi-jat May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/unikontainers/unikontainers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ func New(bundlePath string, containerID string, rootDir string, cfg *UruncConfig
return nil, err
}

if spec == nil || spec.Linux == nil {
return nil, fmt.Errorf("invalid OCI spec: linux section is required")
}

containerName := spec.Annotations["io.kubernetes.cri.container-name"]
if containerName == "queue-proxy" {
uniklog.Warn("This is a queue-proxy container. Adding IP env.")
Expand Down Expand Up @@ -125,6 +129,9 @@ func Get(containerID string, rootDir string) (*Unikontainer, error) {
if err != nil {
return nil, err
}
if spec == nil || spec.Linux == nil {
return nil, fmt.Errorf("invalid OCI spec: linux section is required")
}
u.BaseDir = containerDir
u.RootDir = rootDir
u.Spec = spec
Expand Down Expand Up @@ -357,7 +364,7 @@ func (u *Unikontainer) Exec(metrics m.Writer) error {

// ExecArgs
// If memory limit is set in spec, use it instead of the config default value
if u.Spec.Linux.Resources.Memory != nil {
if u.Spec.Linux.Resources != nil && u.Spec.Linux.Resources.Memory != nil {
if u.Spec.Linux.Resources.Memory.Limit != nil {
if *u.Spec.Linux.Resources.Memory.Limit > 0 {
vmmArgs.MemSizeB = uint64(*u.Spec.Linux.Resources.Memory.Limit) // nolint:gosec
Expand Down