fix: validate Linux spec early to prevent nil dereference panics#650
Open
rishi-jat wants to merge 2 commits into
Open
fix: validate Linux spec early to prevent nil dereference panics#650rishi-jat wants to merge 2 commits into
rishi-jat wants to merge 2 commits into
Conversation
Signed-off-by: Rishi Jat <rishijat098@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
/cc @cmainas |
cmainas
reviewed
May 11, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Hello @rishi-jat ,
I have added a small comment regarding the new error. Other than it looks ok.
rishi-jat
force-pushed
the
fix-linux-spec-nil-checks
branch
from
6391dbd to
3eff01d
Compare
Author
PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate the OCI Linux spec early during container initialization and retrieval to prevent nil dereference panics caused by unsafe access to Spec.Linux.
This change establishes the Linux spec invariant once in:
and returns an explicit error when the Linux section is missing.
Additionally, Exec() now guards access to Spec.Linux.Resources.Memory since Resources remains optional even when the Linux spec is present.
Related issues
How was this tested?
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).