Skip to content

Conversation

@spline2hg
Copy link

Summary

Fixes #379

Changes urunc-deploy to install all artifacts under /opt/urunc directory instead of scattering them across multiple directories. Also auto-generates /etc/urunc/config.toml with the correct paths.

@netlify
Copy link

netlify bot commented Jan 22, 2026

Deploy Preview for urunc ready!

Name Link
🔨 Latest commit 011f2f2
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/697245cbc533ae00084e9bcc
😎 Deploy Preview https://deploy-preview-387--urunc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…runc config

Signed-off-by: spline2hg <181270613+spline2hg@users.noreply.github.com>
@spline2hg spline2hg force-pushed the urunc-deploy-config branch from 4b61cd6 to ce21fa6 Compare January 22, 2026 05:39
@spline2hg
Copy link
Author

Hi @cmainas , can u please take a look and let me know if any more changes are required. Thanks!

Copy link
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @spline2hg ,

thank you for this PR. Overall, it looks good, but there are a few points that we could improve:

  • Could you also update this subsection in the documentation which is related to urunc-deploy?
  • I think there is no reason for the install script to "generate" the config file, since most of the values are static. We can change that in the future, where we allow specific configuration options during deployment to pass to the configuration. However, for the time being (and as first iteration) we can simply use a static file that the script installs like any other artifact.

Signed-off-by: spline2hg <181270613+spline2hg@users.noreply.github.com>
Signed-off-by: spline2hg <181270613+spline2hg@users.noreply.github.com>
…emu data

Signed-off-by: spline2hg <181270613+spline2hg@users.noreply.github.com>
@spline2hg spline2hg requested a review from cmainas January 22, 2026 13:55
Copy link
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @spline2hg ,

please do not perform changes that are not related to the respective PR/issue.

Also, I do not understand why urunc should be updated to search /opt/urunc; it should only check /usr/share. The monitor artifacts and files are not urunc specific ones. They can be system wide (e.g. installation through a package manager). This adds unnecessary overhead and users are already able to specify any directory through the config.

Signed-off-by: spline2hg <181270613+spline2hg@users.noreply.github.com>
@spline2hg
Copy link
Author

Yes @cmainas, sorry about that, I got a bit confused there. I have removed the unrelated changes.

@spline2hg spline2hg requested a review from cmainas January 22, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a basic urunc configuration with urunc-deploy

2 participants