Improve type hints on public interface

[roberto-arista]

Hey!

I've recently noticed a couple of issues with hints:

• some **kwargs wrongly hinted as dict[str, something]
• missing return type hints (pyright does infer most of them but mypy instead defaults to Any, so better specify them)

I've also left a few comments on the code on hints/validations that I'd like an input from you. I'll try to expose them as discussions here in the PR thread.

I propose to open a separate PR to complete the ruff integration. They can probably go in parallel.

[roberto-arista]

morning! @typemytype could you have a look at the PR? thanks : )

[justvanrossum]

I think you should first make sure that the CI doesn't fail. There's currently a mypy error.

[roberto-arista]

Sure, I'll take care of it. I am curious to know what @typemytype thinks of the open discussions : )

[typemytype]

fixed the tests

only the fontVariations resetVariations

[roberto-arista]

I have updated the fontVariations to include resetVariations (and mirror the openTypeFeatures example), but then the test is failing...

[roberto-arista]

I also took the liberty to move all the examples in the docstrings to newPage() from size(), since I remember it being preferred. And in this way the examples are more consistent. I didn't touch the scripts in the test folder, I can do that as well if you prefer.

[justvanrossum]

I also took the liberty to move all the examples in the docstrings to newPage() from size(), since I remember it being preferred

I am not aware of that preference. Either way, such a change should not be part of a PR that intends to add type annotations.

The test failure seems to be that the example script and the expected image are out of sync (script draw three lines, expected image only contains two):

[roberto-arista]

I am not aware of that preference. Either way, such a change should not be part of a PR that intends to add type annotations.

I see your point, but since I've done some corrections to the docstrings in this PR, I thought to add this as well. Type hints add some form of functionalities for IDEs, but in the end they are documentation. I see both falling under the same umbrella. Either way, I can revert it, no problem.

[typemytype]

looks good to me!