Skip to content

adding align while calculating text bounds#599

Merged
typemytype merged 1 commit into
masterfrom
textBoxCharacterBounds+align
May 20, 2026
Merged

adding align while calculating text bounds#599
typemytype merged 1 commit into
masterfrom
textBoxCharacterBounds+align

Conversation

@typemytype
Copy link
Copy Markdown
Owner

@typemytype typemytype commented May 19, 2026

align is an unused argument to calculate the text bounds but required if a plain string is provided instead of a FormatteddString

@typemytype typemytype requested a review from justvanrossum May 19, 2026 11:00
@typemytype
Copy link
Copy Markdown
Owner Author

typemytype commented May 19, 2026

the failed booleanoperation tests are fixed in #583
not fixing this in this PR

@justvanrossum
Copy link
Copy Markdown
Collaborator

Can you edit the description so it says what this PR fixes and/or why the change is needed?

@typemytype
Copy link
Copy Markdown
Owner Author

edited

@typemytype typemytype merged commit f396149 into master May 20, 2026
1 check failed
@typemytype typemytype deleted the textBoxCharacterBounds+align branch May 20, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants