Skip to content

Fix for breaking links with only # as href #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sean-mystyle wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for breaking links with only # as href #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcbc01f
Fix for anchor links with no ID
sean-mystyle Sep 24, 2019
6706260
updated info for fork
sean-mystyle Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions js/jquery.plusanchor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/*
* PlusAnchor
* A form component library
* Version: "1.1.2"
* A simple jQuery plugin that scrolls to anchor links instead of instantaneously jumping to them.
* Version: "1.1.2.1"
* Jamy Golden
* https://github.com/JamyGolden/PlusAnchor
* Fork: sean@onegiantmedia.com | https://github.com/sean-mystyle/PlusAnchor
* License: MIT
*/
(function($){
*/(function($){

function scrollToEvent(base) {
return function(e) {
Expand Down Expand Up @@ -34,15 +34,15 @@
var bodyEl = document.body;

function _constructor() {
// If the user selects body, make sure to use 'html, body' for
// If the user selects body, make sure to use 'html, body' for
// cross browser compatibility reasons
base.el = el;
base.el = el;
base.$el = (el === htmlEl || el === bodyEl) ? $('html, body') : $(el);
base.$animationTarget = options.animationTarget ? $(options.animationTarget) : base.$el;
base.$el.data('plusAnchor', base); // Add a reverse reference to the DOM object
base.animateScrolling = animateScrolling;

var anchorSelector = options.includeCssIndication ? '.js-plus-anchor' : 'a[href^="#"]';
var anchorSelector = options.includeCssIndication ? '.js-plus-anchor' : 'a[href^="#"]:not([href="#"])';// only select anchor links that are not # by itself

// Check for plusanchor disable
if (options === false) {
Expand Down