Fix for breaking links with only # as href #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fix for breaking links that have '#' placeholder hrefs as is common in javascript enabled links. The new query excludes href='#'
added fork reference until merged back
|
Hi @sean-mystyle , thank you for your pull request! I should note that this fork hasn't been touched/maintained for several years. Perhaps this PR can be issued to the original repo this was forked from https://github.com/JamyGolden/PlusAnchor? |
Author
|
Yours was further along than the original by a couple years and a couple
less bugs, actually. Don't worry about merging it if you don't want to, I
have my own fork, I just wanted to share it with you since yours already
fixed one of the issues with the code.
Cheers
…On Tue, Sep 24, 2019 at 1:53 PM Lev Kanter ***@***.***> wrote:
Hi @sean-mystyle <https://github.com/sean-mystyle> , thank you for your
pull request! I should note that this fork hasn't been touched/maintained
for several years. Perhaps this PR can be issued to the original repo this
was forked from https://github.com/JamyGolden/PlusAnchor?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=ADCYKJPNYJNI4WLBY544CU3QLJ44RA5CNFSM4I2EQURKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PYTGY#issuecomment-534743451>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADCYKJI2H2VM4WIWMWG2ZNDQLJ44RANCNFSM4I2EQURA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for links with only # as href. You can change the header info if you want if merged back.