Fix IntlExtension::formatDateTime use of date formatter prototype#3844
Closed
drjayvee wants to merge 4 commits intotwigphp:3.xfrom
Closed
Fix IntlExtension::formatDateTime use of date formatter prototype#3844drjayvee wants to merge 4 commits intotwigphp:3.xfrom
drjayvee wants to merge 4 commits intotwigphp:3.xfrom
Conversation
See twigphp/intl-extra#6 for more details
Member
|
It would be great to have tests to prevent regressions. |
Author
Voilà! |
stof
reviewed
Jun 8, 2023
added 2 commits
June 27, 2023 10:13
Contributor
|
Thank you @drjayvee. |
fabpot
added a commit
that referenced
this pull request
Oct 27, 2023
…totype (drjayvee) This PR was squashed before being merged into the 3.x branch. Discussion ---------- Fix IntlExtension::formatDateTime use of date formatter prototype See twigphp/intl-extra#6 for more details Commits ------- c75762c Fix IntlExtension::formatDateTime use of date formatter prototype
Contributor
|
Merged |
Contributor
|
This change seems to break the fallback of using the timezone set in twigs if (false === $formatterTimezone) {
$formatterTimezone = $date->getTimezone();
Quickfix would be to use: if (null === $formatterTimezone) {
$formatterTimezone = $date->getTimezone(); |
keulinho
added a commit
to keulinho/Twig
that referenced
this pull request
Nov 3, 2023
This is probably a regression from twigphp#3844
fabpot
added a commit
that referenced
this pull request
Nov 21, 2023
…ulinho) This PR was merged into the 3.x branch. Discussion ---------- Fix timezone fallback to CoreExtension in IntlExtension This is probably a regression from #3844 Refer to my comment on the original MR: #3844 (comment) Commits ------- 144c4da Fix timezone fallback to CoreExtension in IntlExtension
symfony-splitter
pushed a commit
to twigphp/intl-extra
that referenced
this pull request
Nov 21, 2023
…ulinho) This PR was merged into the 3.x branch. Discussion ---------- Fix timezone fallback to CoreExtension in IntlExtension This is probably a regression from #3844 Refer to my comment on the original MR: twigphp/Twig#3844 (comment) Commits ------- 144c4dac Fix timezone fallback to CoreExtension in IntlExtension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See twigphp/intl-extra#6 for more details